Skip to content

Conversation

@nikosdouvlis
Copy link
Member

Description

Why?

  • We want to be able to control when captcha is bypassed on a per-instance or per-provider level.
  • We want to rollout these changes gradually to ensure that changes in bot detection logic have no negative impact in sing up conversions.

How?

This PR introduces the displayConfig.captchaOauthBypass field to replace the hard-coded values in clerk-js. The bypassed strategies will now be controlled by FAPI instead. If for any reason FAPI needs to be rolled back, clerk-js will bypass captcha for google/ microsoft/ apple oauth as it does at the moment.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2024

🦋 Changeset detected

Latest commit: ebe049d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@clerk/clerk-js Patch
@clerk/types Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/elements Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/localizations Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
@clerk/shared Patch
@clerk/tanstack-start Patch
@clerk/testing Patch
@clerk/themes Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nikosdouvlis nikosdouvlis merged commit 2ba2fd1 into main Oct 14, 2024
20 of 21 checks passed
@nikosdouvlis nikosdouvlis deleted the nikos/user-858-dynamically-bypass-captcha-for-oauth-providers branch October 14, 2024 13:40
anagstef pushed a commit that referenced this pull request Oct 15, 2024
izaaklauer pushed a commit that referenced this pull request Oct 17, 2024
wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants