Skip to content

Conversation

@anagstef
Copy link
Member

Description

This PR adds the ?render=explicit query param on the CF Turnstile script URL.

Currently, the script is working because the Turnstile script fallbacks to 'explicit' rendering when there is no cf-turnstile element in the DOM, and we use clerk-captcha and clerk-invisible-captcha for the DOM elements.

However, it's better to be explicit about the rendering strategy so that we can avoid accidental issues in the future.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@anagstef anagstef requested a review from nikosdouvlis October 15, 2024 13:00
@anagstef anagstef self-assigned this Oct 15, 2024
@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2024

🦋 Changeset detected

Latest commit: 410626f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@anagstef
Copy link
Member Author

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @anagstef - the snapshot version command generated the following package versions:

Package Version
@clerk/chrome-extension 1.3.20-snapshot.ve5fa754
@clerk/clerk-js 5.26.6-snapshot.ve5fa754
@clerk/clerk-expo 2.2.26-snapshot.ve5fa754

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/chrome-extension@1.3.20-snapshot.ve5fa754 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.26.6-snapshot.ve5fa754 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@2.2.26-snapshot.ve5fa754 --save-exact

@anagstef anagstef changed the title fix(clerk-js): Add the render query param on the script fix(clerk-js): Add the render query param on the captcha script Oct 15, 2024
Co-authored-by: panteliselef <panteliselef@outlook.com>
@nikosdouvlis nikosdouvlis merged commit 48421fe into main Oct 15, 2024
19 of 21 checks passed
@nikosdouvlis nikosdouvlis deleted the stefanos/user-867-add-renderexplicit-on-the-cloudflare-script-file branch October 15, 2024 16:27
anagstef added a commit that referenced this pull request Oct 16, 2024
Co-authored-by: panteliselef <panteliselef@outlook.com>
izaaklauer pushed a commit that referenced this pull request Oct 17, 2024
Co-authored-by: panteliselef <panteliselef@outlook.com>
nikosdouvlis pushed a commit that referenced this pull request Oct 17, 2024
… [Core 1 backport] (#4341)

Co-authored-by: panteliselef <panteliselef@outlook.com>
wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
Co-authored-by: panteliselef <panteliselef@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants