feat(express): Export authenticateRequest
#4340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be useful to use directly for express users who want to go down to bare metal
🦋 Changeset detectedLatest commit: b3552cc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wobsoriano
approved these changes
Oct 15, 2024
Member
wobsoriano
left a comment
wobsoriano
left a comment
There was a problem hiding this comment.
Yeah, let's do this. This one has custom logic that would be a hassle to implement in userland
LekoArts
changed the title
authenticateRequest
LekoArts
approved these changes
Oct 16, 2024
|
Thanks guys. This will lead to a significantly more straightforward implementation of auth guards in Nest.js. Appreciate your work. |
wobsoriano
pushed a commit
that referenced
this pull request
Feb 8, 2025
Co-authored-by: LekoArts <lekoarts@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be useful to use directly for express users who want to go down to bare metal
Description
For some users of the express SDK, they may want to directly use
authenticateRequest, which is notably different from the backend SDK version since it's adapted to express' request wrapper. This makes that possible.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change