fix(nextjs): Improve page detection for Next 15 #4383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b528e16 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The `next-url` exists while in dev mode, but it's missing in the production build so we need to update our fallback detection as well.
panteliselef
force-pushed
the
elef/sdki-717-update-page-detection-currently-broken-for-next-15
branch
from
a0d0ff2 to
b528e16
Compare
dstaley
approved these changes
Oct 22, 2024
panteliselef
deleted the
elef/sdki-717-update-page-detection-currently-broken-for-next-15
branch
wobsoriano
pushed a commit
that referenced
this pull request
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In next 15, the
next-urlheader exists while in dev mode, but it's missing in the production build so we need to update our fallback detection as well.Also
__fetch.__nextGetStaticStore().getStore().pagePathhas been replaced with__fetch.__nextGetStaticStore().getStore().page.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change