Skip to content

fix(clerk-js): Fix issue for legal consent checkbox showing up in when disabled #4403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 24, 2024
Merged

fix(clerk-js): Fix issue for legal consent checkbox showing up in when disabled #4403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c85913
fix(clerk-js): Fix issue for legal consent checkbox showing up in whe…
octoper Oct 24, 2024
fba8f8b
chore(repo): Add changeset
octoper Oct 24, 2024
4fc4e2c
chore(clerk-js): Rename variable name
octoper Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/unlucky-coins-juggle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@clerk/clerk-js": patch
---

Fix for legal consent rendered on the <SignUp/> component when only social sign up is enabled
5 changes: 3 additions & 2 deletions packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,14 +103,15 @@ function _SignUpStart(): JSX.Element {
const hasTicket = !!formState.ticket.value;
const hasEmail = !!formState.emailAddress.value;
const isProgressiveSignUp = userSettings.signUp.progressive;
const isLegalConsentEnabled = userSettings.signUp.legal_consent_enabled;

const fields = determineActiveFields({
attributes,
hasTicket,
hasEmail,
activeCommIdentifierType,
isProgressiveSignUp,
legalConsentRequired: userSettings.signUp.legal_consent_enabled,
legalConsentRequired: isLegalConsentEnabled,
});

const handleTokenFlow = () => {
Expand Down Expand Up @@ -293,7 +294,7 @@ function _SignUpStart(): JSX.Element {
/>
)}
</SocialButtonsReversibleContainerWithDivider>
{!shouldShowForm && (
{!shouldShowForm && isLegalConsentEnabled && (
<Form.ControlRow elementId='__experimental_legalAccepted'>
<LegalCheckbox
{...formState.__experimental_legalAccepted.props}
Expand Down
Loading