feat(clerk-js): Add nonce to theme provider #4509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f10d02d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jescalan
force-pushed
the
je.nonce-style
branch
from
ff94d7f to
af9643f
Compare
jacekradko
approved these changes
Nov 22, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
wobsoriano
pushed a commit
that referenced
this pull request
Feb 8, 2025
Co-authored-by: Jacek <jacek@clerk.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If using a strict-dynamic CSP with Clerk, you still currently need to add
unsafe-inlineto thestyle-srcproperty since we do not thread the nonce into the emotion cache. This change will make it such that you can run the nonce intostyle-srcinstead ofunsafe-inlineand it will work, which means there are no unsafe properties required to be passed for strict dynamic policies when using Clerk in production.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change