chore(clerk-js): Use fapi error long message instead of statusText when throwing API errors #4511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Customized error for using production keys in dev.
🦋 Changeset detectedLatest commit: d309959 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
commented
Nov 7, 2024
| ); | ||
| } | ||
|
|
||
| throw new ClerkAPIResponseError(safeErrorMessage || statusText, { |
Member
Author
There was a problem hiding this comment.
statusTextwas empty most of the time (not sure why,statuswas populated)- We do have a custom
toString()forClerkAPIResponseErrorbut that is not guaranteed to be called.
anagstef
reviewed
Nov 7, 2024
…ge-feedback-when-running-on-local-with
LekoArts
approved these changes
Nov 11, 2024
anagstef
approved these changes
Nov 11, 2024
panteliselef
deleted the
elef/sdki-727-improve-error-message-feedback-when-running-on-local-with
branch
wobsoriano
pushed a commit
that referenced
this pull request
Feb 8, 2025
…en throwing API errors (#4511)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use FAPI error long message instead of statusText when throwing API errors
Also a customized error for using production keys in dev is added.
Before
After
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change