Skip to content

Conversation

@alexcarpenter
Copy link
Member

@alexcarpenter alexcarpenter commented Nov 7, 2024

Description

  • Ensures the inferredBasePath is correct by removing catch-all paths
  • Fixes issue where a shallowPush was being triggered in sign-in/up init events causing the URL to be incorrect when navigating between the flows
  • Remove passing router from @clerk/nextjs to clerk-js and @clerk/elements, the current approach was causing issues with incorrect router state being exposed
  • Fixes dependencies between @clerk/elements and @clerk/nextjs where multiple version of @clerk/shared were getting pulled in

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2024

🦋 Changeset detected

Latest commit: 5b2031b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@clerk/elements Patch
@clerk/nextjs Patch
@clerk/shared Patch
@clerk/types Patch
@clerk/clerk-js Patch
@clerk/ui Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/chrome-extension Patch
@clerk/expo-passkeys Patch
@clerk/clerk-expo Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
@clerk/tanstack-start Patch
@clerk/testing Patch
@clerk/localizations Patch
@clerk/themes Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brkalow brkalow changed the title fix(elements,nextjs,shared,types): Ensure paths are correct within elements flows fix(elements): Fix elements router usage Nov 7, 2024
…ub.com:clerk/javascript into alexcarpenter/fix-clerkrouter-elements-routing
@alexcarpenter alexcarpenter requested a review from dstaley November 7, 2024 18:01
@brkalow brkalow merged commit f7472e2 into main Nov 8, 2024
22 of 23 checks passed
@brkalow brkalow deleted the alexcarpenter/fix-clerkrouter-elements-routing branch November 8, 2024 03:21
wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
Co-authored-by: Bryce Kalow <bryce@clerk.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants