Skip to content

feat(clerk-js,types): Surface enterprise accounts in UserProfile #4518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Nov 13, 2024
Merged

feat(clerk-js,types): Surface enterprise accounts in UserProfile #4518

merged 21 commits into from
Nov 13, 2024

Conversation

@LauraBeatris
Copy link
Member

@LauraBeatris LauraBeatris commented Nov 7, 2024 •
edited
Loading

Description

Resolves ORGS-293, ORGS-294

Surfaces user.enterprise_accounts instead of user.saml_accounts. This is going to support multiple enterprise protocols from now on, such as OpenID connect.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@LauraBeatris LauraBeatris self-assigned this Nov 7, 2024
@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: e71267b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 21 packages
Name Type
@clerk/clerk-js Minor
@clerk/types Minor
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/elements Patch
@clerk/expo-passkeys Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/localizations Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
@clerk/shared Patch
@clerk/tanstack-start Patch
@clerk/testing Patch
@clerk/themes Patch
@clerk/ui Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LauraBeatris LauraBeatris force-pushed the laura/orgs-293-display-enterprise-accounts-from-userenterprise_accounts branch 2 times, most recently from 27932f1 to 4b3eb72 Compare November 7, 2024 20:47
@LauraBeatris LauraBeatris force-pushed the laura/orgs-293-display-enterprise-accounts-from-userenterprise_accounts branch 2 times, most recently from db250d9 to 6a5ddaa Compare November 7, 2024 21:17
@LauraBeatris LauraBeatris changed the title feat(clerk-js,backend,types): Display enterprise accounts on UserProfile feat(clerk-js,types): Display enterprise accounts on UserProfile Nov 7, 2024
@LauraBeatris LauraBeatris force-pushed the laura/orgs-293-display-enterprise-accounts-from-userenterprise_accounts branch 4 times, most recently from 1815e12 to 16eda49 Compare November 8, 2024 00:24
@LauraBeatris LauraBeatris changed the title feat(clerk-js,types): Display enterprise accounts on UserProfile feat(clerk-js,types): Support multiple enterprise protocols in UserProfile Nov 8, 2024
@LauraBeatris LauraBeatris force-pushed the laura/orgs-293-display-enterprise-accounts-from-userenterprise_accounts branch from 16eda49 to 094f540 Compare November 8, 2024 00:44
@LauraBeatris LauraBeatris force-pushed the laura/orgs-293-display-enterprise-accounts-from-userenterprise_accounts branch from 094f540 to e5aa840 Compare November 8, 2024 00:46
LauraBeatris
LauraBeatris commented Nov 8, 2024
View reviewed changes
@LauraBeatris LauraBeatris force-pushed the laura/orgs-293-display-enterprise-accounts-from-userenterprise_accounts branch from e5aa840 to d270ba9 Compare November 12, 2024 17:39
@LauraBeatris LauraBeatris changed the title feat(clerk-js,types): Support multiple enterprise protocols in UserProfile feat(clerk-js,types): Surface enterprise accounts in UserProfile Nov 12, 2024
@LauraBeatris LauraBeatris force-pushed the laura/orgs-293-display-enterprise-accounts-from-userenterprise_accounts branch from 1a29195 to e019947 Compare November 12, 2024 18:03
@LauraBeatris LauraBeatris force-pushed the laura/orgs-293-display-enterprise-accounts-from-userenterprise_accounts branch from e019947 to d21ba70 Compare November 12, 2024 18:03
@LauraBeatris
Copy link
Member Author

LauraBeatris commented Nov 12, 2024

@NicolasLopes7 Preserving the disableAdditionalIdentifications check:

CleanShot 2024-11-12 at 15 33 01

CleanShot.2024-11-12.at.15.31.01.mp4

@LauraBeatris LauraBeatris force-pushed the laura/orgs-293-display-enterprise-accounts-from-userenterprise_accounts branch 2 times, most recently from 6751683 to 3a253db Compare November 13, 2024 17:08
panteliselef
panteliselef approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@panteliselef panteliselef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛳️

@LauraBeatris
Add EnterpriseAccount resource to backend layer
eced539
@LauraBeatris
Add EnterpriseAccount to types layer
a3ca6c9
@LauraBeatris
Add EnterpriseAccountResource to clerk-js
107dc77
@LauraBeatris
Populate enterprise_accounts on User resource
0fe99f8
@LauraBeatris
Verify if there are enterprise accounts to display
7b6c6de
@LauraBeatris
Update UI description with new enterprise provider union
c83c34b 
Previously, SAML was the only supported enterprise type, therefore the UI description was only based on `SamlIdpSlug`

It'll now use `EnterpriseProvider` to handle multiple connection types.
@LauraBeatris
Display enterprise accounts from User resource
b18329d 
Using `user.enterpriseAccounts` to display on `UserProfile`, instead of `user.samlAccounts`

This is going to support the upcoming connection types such as EASIE, OIDC

Also, deletes `useSaml` hook as it was a weak abstraction around SAML constants for logo URLs and naming
@LauraBeatris
Disallow user profile changes for multiple enterprise connection types
9ae6104 
Refer to `user.enterprise_accounts` to verify if the user is allowed to introduce additional identifications
@LauraBeatris
Introduce UI tests
7f5056d
@LauraBeatris
Fix icon for SAML providers
f6e67ee
@LauraBeatris
Update changeset
0b2e26f
@LauraBeatris
Update firstName and lastName to be nullable
b037709
@LauraBeatris
Update tests to rely on enterprise_accounts
efa346e
@LauraBeatris
Add deprecation JSDocs
38750b2
@LauraBeatris
Treat provider as strategy
75c913b
@LauraBeatris
Add test for inactive connection
63c8e3c
@LauraBeatris
Add generic descriptor for SSO connections
6f33bb6
@LauraBeatris
Include generic providerInitialIcon descriptor
2c3ec62
@LauraBeatris
Preserve ProviderInitialIcon descriptors
3e3cee6
@LauraBeatris
Rely on FAPI for connection name and logo
d4cdd22
@LauraBeatris LauraBeatris force-pushed the laura/orgs-293-display-enterprise-accounts-from-userenterprise_accounts branch from 3a253db to d4cdd22 Compare November 13, 2024 18:09
@LauraBeatris LauraBeatris merged commit 1c0b500 into main Nov 13, 2024
24 checks passed
@LauraBeatris LauraBeatris deleted the laura/orgs-293-display-enterprise-accounts-from-userenterprise_accounts branch November 13, 2024 20:22
@clerk-cookie clerk-cookie mentioned this pull request Nov 13, 2024
Merged
wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
@LauraBeatris @wobsoriano
feat(clerk-js,types): Surface enterprise accounts in UserProfile (#…
5662c59 
…4518)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicolasLopes7 NicolasLopes7 NicolasLopes7 left review comments

@panteliselef panteliselef panteliselef approved these changes

@alexcarpenter alexcarpenter Awaiting requested review from alexcarpenter

+2 more reviewers

@Nikpolik Nikpolik Nikpolik left review comments

@izaaklauer izaaklauer izaaklauer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LauraBeatris LauraBeatris

Labels

clerk-js types

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@LauraBeatris @alexcarpenter @izaaklauer @Nikpolik @panteliselef @NicolasLopes7 @clerk-cookie