-
Notifications
You must be signed in to change notification settings - Fork 408
fix(clerk-js,types): Introduce experimental.rethrowOfflineNetworkErrors Clerk option to enable rethrowing network errors
#4525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
anagstef
merged 12 commits into
main
from
stefanos/eco-230-propagate-network-errors-when-on-expo-instead-of-muting-them
Nov 13, 2024
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6db56a7
fix(expo): Stop silencing network errors when on Expo
anagstef 6ff0836
Merge branch 'main' into stefanos/eco-230-propagate-network-errors-wh…
anagstef 7304909
Merge branch 'main' into stefanos/eco-230-propagate-network-errors-wh…
anagstef 4bb11cf
Update .changeset/two-bags-rhyme.md
anagstef eab4eb7
Introduce `experimental.rethrowOfflineNetworkErrors` Clerk Option
anagstef e63917d
Merge branch 'main' into stefanos/eco-230-propagate-network-errors-wh…
anagstef 123daa6
Remove the env variable from Expo
anagstef ce58447
Fix changeset
anagstef b069571
Throw ClerkRuntimeError
anagstef c8b87b2
Change changeset to minor
anagstef d496d67
Merge branch 'main' into stefanos/eco-230-propagate-network-errors-wh…
anagstef a77fcda
Add TODO comment
anagstef File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| '@clerk/clerk-js': minor | ||
| '@clerk/types': minor | ||
| --- | ||
|
|
||
| Introduce the `experimental.rethrowOfflineNetworkErrors` option to the `ClerkProvider` component. | ||
|
|
||
| When set to `true`, Clerk will rethrow network errors that occur while the user is offline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.