fix(clerk-js,clerk-react,chrome-extension): Build and consume packages without remotely hosted code #4551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d7f9da1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
!allow-major |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
tmilewski
commented
Nov 14, 2024
| export * from './runtime'; | ||
| export * from './url'; | ||
| export * from './web3'; | ||
| export * from './windowNavigate'; |
There was a problem hiding this comment.
Removes a number of duplicated exports.
jacekradko
reviewed
Nov 14, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
royanger
approved these changes
Nov 18, 2024
tmilewski
force-pushed
the
tm/ext-updates
branch
from
16ba756 to
ee2664a
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@jacekradko @brkalow Mind taking another once-over here? Once this is pulled into the upstream extension updates PR, we're planning on releasing this via that. |
brkalow
approved these changes
Nov 22, 2024
tmilewski
force-pushed
the
tm/ext-updates
branch
from
ee2664a to
1b8d68a
Compare
without remotely hosted code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes remotely hosted code (RHC) for Browser Extensions in the following fashion:
clerk-jsRemoves RHC via
__BUILD_DISABLE_RHC__and creates a new build under@clerk/clerk-js/no-rhc.clerk-reactIntroduces
__BUILD_DISABLE_RHC__into theclerk-reactbuild which, if unset, defaults tofalse.clerk-reactis bundled intochrome-extensionand in that process__BUILD_DISABLE_RHC__is set totruewhich ultimately removes the RHC.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change