Skip to content

Conversation

@LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Dec 10, 2024

Description

  • Add and activate E2E tests for React Router SDK
  • Add some JSDoc comments here and there
  • Allow VITE_ prefixed env vars for the new redirect URL options

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2024

🦋 Changeset detected

Latest commit: 14ef525

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/react-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 2:26pm

@LekoArts LekoArts changed the title chore(react-router): Add E2E tests fix(react-router): Add E2E tests & improve redirect URL env var loading Dec 10, 2024
@LekoArts LekoArts marked this pull request as ready for review December 10, 2024 14:33
@LekoArts LekoArts merged commit 4ed3754 into main Dec 10, 2024
33 checks passed
@LekoArts LekoArts deleted the lekoarts/eco-265-add-e2e-tests-for-react-router branch December 10, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants