-
Notifications
You must be signed in to change notification settings - Fork 407
feat(clerk-js): Launch sign-in-or-up flow #4788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
8ed1cc9
chore: remove experimental check
alexcarpenter 273f234
check for empty signUpUrl
alexcarpenter 37f3f57
Update SignInProps
alexcarpenter 79cadb9
update checks
alexcarpenter 59b519b
merge
alexcarpenter 3b63877
Merge branch 'main' into alexcarpenter/sign-in-or-up-ga
jacekradko 454f1cf
add changeset
alexcarpenter ec51e41
update tests
alexcarpenter aa0245a
fix path
alexcarpenter efc25c1
remove sign_up_url
alexcarpenter 11f257d
Merge branch 'main' into alexcarpenter/sign-in-or-up-ga
alexcarpenter 8320207
Merge branch 'main' into alexcarpenter/sign-in-or-up-ga
alexcarpenter 39aae7d
feat(clerk-js,react,types): Add option to enable combined flow at com…
alexcarpenter d26ff82
Merge branch 'main' into alexcarpenter/sign-in-or-up-ga
alexcarpenter 5dc7940
refactor(e2e): Update sign-in-or-up tests (#4872)
alexcarpenter 042d101
Merge branch 'main' into alexcarpenter/sign-in-or-up-ga
alexcarpenter a549423
add express tag
alexcarpenter 0e6fbcb
move back to protected page test
alexcarpenter d7e2383
remove combined props usage
alexcarpenter a8deaa3
fix(clerk-js): Use correct email link redirect_url based on intent (#…
dstaley 130f17c
Merge branch 'alexcarpenter/sign-in-or-up-ga' of github.com:clerk/jav…
alexcarpenter d516c26
fix email link paths
alexcarpenter e14de2a
Update packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx
alexcarpenter 055fdb7
Update packages/clerk-js/src/ui/common/redirects.ts
alexcarpenter 361cf90
Update packages/clerk-js/src/ui/contexts/components/SignIn.ts
alexcarpenter 8136c40
Merge branch 'alexcarpenter/sign-in-or-up-ga' of github.com:clerk/jav…
alexcarpenter c77b8e7
format
alexcarpenter 68324d7
bring back fallback
alexcarpenter 4545e77
fix(nextjs): Handle dynamicIO errors when request apis are accessed o…
panteliselef b38298d
fix(localizations): Force interpolation for `socialButtonsBlockButton…
panteliselef 5c842f8
fix(chrome-extension): Bundle @clerk/shared to properly tree-shake (#…
LekoArts 5b82f80
Merge branch 'main' into alexcarpenter/sign-in-or-up-ga
jacekradko e0f4a6e
Delete .changeset/cuddly-shrimps-fold.md
alexcarpenter e1aef02
add changeset
alexcarpenter b8941e8
Merge branch 'alexcarpenter/sign-in-or-up-ga' of github.com:clerk/jav…
alexcarpenter cd9a4a4
Delete .changeset/two-doors-visit.md
alexcarpenter 8a33145
Merge branch 'main' into alexcarpenter/sign-in-or-up-ga
jacekradko 6e8a4ab
Update .changeset/tough-bugs-vanish.md
alexcarpenter bee4012
add withSignUp prop to vue SignInButton
alexcarpenter f559bd1
Update .changeset/tough-bugs-vanish.md
alexcarpenter ae62b50
remove combinedFlow prop from provider
alexcarpenter 25ff0df
Merge branch 'alexcarpenter/sign-in-or-up-ga' of github.com:clerk/jav…
alexcarpenter 183a626
fix(clerk-js): Preserve __clerk_ticket for internal sign-in navigatio…
brkalow 51074b6
Merge branch 'main' into alexcarpenter/sign-in-or-up-ga
alexcarpenter c1d59b5
fix test
alexcarpenter 6458707
remove email link test changes
alexcarpenter 9c2dd6b
Merge branch 'main' into alexcarpenter/sign-in-or-up-ga
alexcarpenter 658a7bf
temp disable email link tests
alexcarpenter f730990
Merge branch 'main' into alexcarpenter/sign-in-or-up-ga
jacekradko f1db0e5
Merge branch 'main' into alexcarpenter/sign-in-or-up-ga
alexcarpenter 63162f6
Update SignInButton.vue
alexcarpenter e1772b3
Fix vue options passing.
brkalow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| '@clerk/clerk-js': minor | ||
| '@clerk/clerk-react': minor | ||
| '@clerk/types': minor | ||
| '@clerk/vue': minor | ||
| --- | ||
|
|
||
| Introduce sign-in-or-up flow. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
integration/templates/next-app-router/src/app/sign-in-or-up/[[...catchall]]/page.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| import { SignIn } from '@clerk/nextjs'; | ||
|
|
||
| export default function Page() { | ||
| return ( | ||
| <div> | ||
| <SignIn | ||
| routing={'path'} | ||
| path={'/sign-in'} | ||
dstaley marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| signUpUrl={'/sign-up'} | ||
| fallback={<>Loading sign in</>} | ||
| withSignUp | ||
| /> | ||
| </div> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.