feat(clerk-react): Render button components before clerk-js load #4810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omponents exposed through clerk/nextjs
🦋 Changeset detectedLatest commit: 14b79fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alexcarpenter
approved these changes
Dec 19, 2024
jakobevangelista
pushed a commit
that referenced
this pull request
Jan 9, 2025
Co-authored-by: Alex Carpenter <alex.carpenter@clerk.dev>
wobsoriano
pushed a commit
that referenced
this pull request
Feb 8, 2025
Co-authored-by: Alex Carpenter <alex.carpenter@clerk.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dependent on #4723
All of our button components currently delay rendering until after clerk-js has loaded. In practice, this is not necessary as
IsomorphicClerkalready handles buffering underlying clerk method calls before load. With this change, the button components will now always render. This should help address any layout shift caused by button component usage.fixes SDKI-814
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change