chore(types,nextjs): Handle types in protect()
#4843
Merged
+34
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
panteliselef
commented
Jan 7, 2025
Comment on lines
+76
to
+90
| export type CheckAuthorizationFromSessionClaims = <P extends OrganizationCustomPermissionKey>( | ||
| isAuthorizedParams: CheckAuthorizationParamsFromSessionClaims<P>, | ||
| ) => boolean; | ||
|
|
||
| export type CheckAuthorizationParamsFromSessionClaims<P extends OrganizationCustomPermissionKey> = WithReverification< | ||
| | { | ||
| role: OrganizationCustomRoleKey; | ||
| permission?: never; | ||
| } | ||
| | { | ||
| role?: never; | ||
| permission: DisallowSystemPermissions<P>; | ||
| } | ||
| | { role?: never; permission?: never } | ||
| >; |
Member
Author
There was a problem hiding this comment.
I simply restructured it, no actual changes were made
LauraBeatris
approved these changes
Jan 7, 2025
LauraBeatris
merged commit 2db90d3
into
laura/orgs-441-do-not-allow-passing-system-permissions-to-has-from-the
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change