Skip to content

Conversation

@kaftarmery
Copy link
Contributor

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2025

🦋 Changeset detected

Latest commit: 756bf45

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 3:28pm

@panteliselef panteliselef changed the title fix(clerk-js) Adjust toast UI interactions fix(clerk-js): Adjust toast UI interactions Jan 13, 2025
Copy link
Member

@mwickett mwickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like where this landed, looks good! Note that I've only reviewed the final experience, this shouldn't be considered a full code review.

@kaftarmery kaftarmery marked this pull request as draft January 15, 2025 14:15
@kaftarmery
Copy link
Contributor Author

I like where this landed, looks good! Note that I've only reviewed the final experience, this shouldn't be considered a full code review.

Thanks Mike! Converted it to draft for the moment until I push the changes for the CSS reset problem. I should have that ready today!

@kaftarmery kaftarmery marked this pull request as ready for review January 15, 2025 15:22
@panteliselef
Copy link
Member

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @panteliselef - the snapshot version command generated the following package versions:

Package Version
@clerk/astro 2.1.8-snapshot.v20250115152439
@clerk/backend 1.22.1-snapshot.v20250115152439
@clerk/chrome-extension 2.1.12-snapshot.v20250115152439
@clerk/clerk-js 5.44.1-snapshot.v20250115152439
@clerk/elements 0.22.8-snapshot.v20250115152439
@clerk/clerk-expo 2.6.11-snapshot.v20250115152439
@clerk/expo-passkeys 0.1.7-snapshot.v20250115152439
@clerk/express 1.3.35-snapshot.v20250115152439
@clerk/fastify 2.1.8-snapshot.v20250115152439
@clerk/localizations 3.9.8-snapshot.v20250115152439
@clerk/nextjs 6.9.11-snapshot.v20250115152439
@clerk/nuxt 1.0.4-snapshot.v20250115152439
@clerk/clerk-react 5.21.3-snapshot.v20250115152439
@clerk/react-router 0.1.9-snapshot.v20250115152439
@clerk/remix 4.4.10-snapshot.v20250115152439
@clerk/shared 2.20.7-snapshot.v20250115152439
@clerk/tanstack-start 0.8.9-snapshot.v20250115152439
@clerk/testing 1.4.8-snapshot.v20250115152439
@clerk/themes 2.2.6-snapshot.v20250115152439
@clerk/types 4.40.3-snapshot.v20250115152439
@clerk/ui 0.3.9-snapshot.v20250115152439
@clerk/vue 1.0.3-snapshot.v20250115152439

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/astro@2.1.8-snapshot.v20250115152439 --save-exact

@clerk/backend

npm i @clerk/backend@1.22.1-snapshot.v20250115152439 --save-exact

@clerk/chrome-extension

npm i @clerk/chrome-extension@2.1.12-snapshot.v20250115152439 --save-exact

@clerk/clerk-js

npm i @clerk/clerk-js@5.44.1-snapshot.v20250115152439 --save-exact

@clerk/elements

npm i @clerk/elements@0.22.8-snapshot.v20250115152439 --save-exact

@clerk/clerk-expo

npm i @clerk/clerk-expo@2.6.11-snapshot.v20250115152439 --save-exact

@clerk/expo-passkeys

npm i @clerk/expo-passkeys@0.1.7-snapshot.v20250115152439 --save-exact

@clerk/express

npm i @clerk/express@1.3.35-snapshot.v20250115152439 --save-exact

@clerk/fastify

npm i @clerk/fastify@2.1.8-snapshot.v20250115152439 --save-exact

@clerk/localizations

npm i @clerk/localizations@3.9.8-snapshot.v20250115152439 --save-exact

@clerk/nextjs

npm i @clerk/nextjs@6.9.11-snapshot.v20250115152439 --save-exact

@clerk/nuxt

npm i @clerk/nuxt@1.0.4-snapshot.v20250115152439 --save-exact

@clerk/clerk-react

npm i @clerk/clerk-react@5.21.3-snapshot.v20250115152439 --save-exact

@clerk/react-router

npm i @clerk/react-router@0.1.9-snapshot.v20250115152439 --save-exact

@clerk/remix

npm i @clerk/remix@4.4.10-snapshot.v20250115152439 --save-exact

@clerk/shared

npm i @clerk/shared@2.20.7-snapshot.v20250115152439 --save-exact

@clerk/tanstack-start

npm i @clerk/tanstack-start@0.8.9-snapshot.v20250115152439 --save-exact

@clerk/testing

npm i @clerk/testing@1.4.8-snapshot.v20250115152439 --save-exact

@clerk/themes

npm i @clerk/themes@2.2.6-snapshot.v20250115152439 --save-exact

@clerk/types

npm i @clerk/types@4.40.3-snapshot.v20250115152439 --save-exact

@clerk/ui

npm i @clerk/ui@0.3.9-snapshot.v20250115152439 --save-exact

@clerk/vue

npm i @clerk/vue@1.0.3-snapshot.v20250115152439 --save-exact

Copy link
Member

@panteliselef panteliselef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@kaftarmery kaftarmery merged commit f877337 into main Jan 15, 2025
29 checks passed
@kaftarmery kaftarmery deleted the mery/keyless-ui-interaction branch January 15, 2025 15:46
wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
Co-authored-by: panteliselef <panteliselef@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants