Skip to content

fix(clerk-js): Only call ensureMounted() if necessary #4876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 14, 2025
Merged

fix(clerk-js): Only call ensureMounted() if necessary #4876

merged 2 commits into from
Jan 14, 2025

Conversation

@brkalow
Copy link
Member

@brkalow brkalow commented Jan 13, 2025 •
edited
Loading

Description

Ensure the clerk-js UI chunks aren't loaded due to the ensureMounted() call within handleKeylessPrompt(), which is only necessary if a specific Clerk option is passed.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 3cc7099

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 3:18pm

@panteliselef panteliselef changed the title fix(clerk-js): only call ensureMounted() if necessary fix(clerk-js): Only call ensureMounted() if necessary Jan 13, 2025
panteliselef
panteliselef approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@panteliselef panteliselef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niceee

jacekradko
jacekradko approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@jacekradko jacekradko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@brkalow brkalow merged commit 43ba063 into main Jan 14, 2025
29 checks passed
@brkalow brkalow deleted the brk.fix/keyless-prompt-bundle branch January 14, 2025 04:06
@clerk-cookie clerk-cookie mentioned this pull request Jan 14, 2025
Merged
wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
@brkalow @wobsoriano
fix(clerk-js): Only call ensureMounted() if necessary (#4876)
e0e35ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacekradko jacekradko jacekradko approved these changes

@panteliselef panteliselef panteliselef approved these changes

Assignees

No one assigned

Labels

clerk-js

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brkalow @jacekradko @panteliselef @clerk-cookie