feat(backend): Set cookies from the refresh token flow #4884
Conversation
🦋 Changeset detectedLatest commit: 3998837 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
| return HttpResponse.json(mockJwks); | ||
| }), | ||
| ); | ||
| describe('refreshToken', async () => { |
There was a problem hiding this comment.
I moved these tests into a separate describe block, consider looking at the diff without whitespace to see the actual changes: https://github.com/clerk/javascript/pull/4884/files?w=1
| // Perform the actual token refresh. | ||
| const tokenResponse = await options.apiClient.sessions.refreshSession(decodeResult.payload.sid, { | ||
| const response = await options.apiClient.sessions.refreshSession(decodeResult.payload.sid, { | ||
| format: 'cookie', |
There was a problem hiding this comment.
Do we want this to be set for every call ? Could this be configured and passed down from authenticateRequest ?
There was a problem hiding this comment.
I don't see a good reason to make it configurable, not setting the cookie allows requests to fire with the expired session token before clerk-js hydrates.
Co-authored-by: panteliselef <panteliselef@outlook.com>
Co-authored-by: panteliselef <panteliselef@outlook.com>
4 participants
Description
Supports the
format=cookiesparameter for the session refresh endpoint. When this parameter is passed, the API will return an array ofset-cookieheader values to be passed along with the response.SDKI-832
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change