Skip to content

Conversation

@brkalow
Copy link
Member

@brkalow brkalow commented Jan 15, 2025

Description

  • Ensure the __clerk_ticket query parameter is preserved when navigating internally.
  • Adds a new searchParams option to our internal router navigate() method to allow passing structured search params, instead of relying on concatenating them onto the to argument.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2025

⚠️ No Changeset found

Latest commit: ad9d944

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 8:27pm

@brkalow brkalow changed the title fix(clerk-js): fix(clerk-js): preserve __clerk_ticket for internal sign-in navigation Jan 15, 2025
@brkalow brkalow changed the title fix(clerk-js): preserve __clerk_ticket for internal sign-in navigation fix(clerk-js): Preserve __clerk_ticket for internal sign-in navigation Jan 15, 2025
@alexcarpenter alexcarpenter merged commit 183a626 into alexcarpenter/sign-in-or-up-ga Jan 15, 2025
9 of 11 checks passed
@alexcarpenter alexcarpenter deleted the brk.fix/invitation-preserve-params branch January 15, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants