fix(clerk-js): Fix layout shift when Smart CAPTCHA executes an interactive challenge #4924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 69f7409 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
!snapshot |
This comment was marked as outdated.
This comment was marked as outdated.
|
!snapshot |
|
Hey @anagstef - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/astro@2.1.10-snapshot.v20250117141324 --save-exact
npm i @clerk/backend@1.23.2-snapshot.v20250117141324 --save-exact
npm i @clerk/chrome-extension@2.1.14-snapshot.v20250117141324 --save-exact
npm i @clerk/clerk-js@5.45.1-snapshot.v20250117141324 --save-exact
npm i @clerk/elements@0.22.10-snapshot.v20250117141324 --save-exact
npm i @clerk/clerk-expo@2.6.13-snapshot.v20250117141324 --save-exact
npm i @clerk/expo-passkeys@0.1.9-snapshot.v20250117141324 --save-exact
npm i @clerk/express@1.3.37-snapshot.v20250117141324 --save-exact
npm i @clerk/fastify@2.1.10-snapshot.v20250117141324 --save-exact
npm i @clerk/localizations@3.9.10-snapshot.v20250117141324 --save-exact
npm i @clerk/nextjs@6.9.13-snapshot.v20250117141324 --save-exact
npm i @clerk/nuxt@1.0.6-snapshot.v20250117141324 --save-exact
npm i @clerk/clerk-react@5.22.1-snapshot.v20250117141324 --save-exact
npm i @clerk/react-router@0.2.0-snapshot.v20250117141324 --save-exact
npm i @clerk/remix@4.4.12-snapshot.v20250117141324 --save-exact
npm i @clerk/shared@2.20.9-snapshot.v20250117141324 --save-exact
npm i @clerk/tanstack-start@0.8.11-snapshot.v20250117141324 --save-exact
npm i @clerk/testing@1.4.10-snapshot.v20250117141324 --save-exact
npm i @clerk/themes@2.2.8-snapshot.v20250117141324 --save-exact
npm i @clerk/types@4.41.1-snapshot.v20250117141324 --save-exact
npm i @clerk/ui@0.3.11-snapshot.v20250117141324 --save-exact
npm i @clerk/vue@1.1.1-snapshot.v20250117141324 --save-exact |
anagstef
requested review from
alexcarpenter,
nikosdouvlis,
octoper and
panteliselef
anagstef
changed the title
octoper
approved these changes
Jan 17, 2025
anagstef
commented
Jan 17, 2025
Comment on lines
+177
to
+178
| visibleWidget.style.minHeight = '68px'; // this is the height of the Turnstile widget | ||
| visibleWidget.style.marginBottom = '1.5rem'; |
There was a problem hiding this comment.
This utility does not have access to our UI design system, so we need to hardcode these values.
nikospapcom
approved these changes
Jan 17, 2025
tmilewski
approved these changes
Jan 17, 2025
panteliselef
approved these changes
Jan 17, 2025
brkalow
deleted the
stefanos/fraud-200-prevent-layout-shift-during-captcha-rendering-in-sign-ups
branch
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the layout shift caused by the Turnstile script, especially when in Smart mode there was no interactive challenge.
Before (Smart without interaction):
before.mp4
After (Smart without interaction):
after-invisible.mp4
After (Smart with interaction):
after-smart.mp4
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change