Skip to content

feat(clerk-js,localizations,types): Add sign in or up subtitle localizations #4988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 24, 2025
Merged

feat(clerk-js,localizations,types): Add sign in or up subtitle localizations #4988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
28221c9
add sign-in-or-up subtitles
alexcarpenter Jan 23, 2025
e3fdb97
generate
alexcarpenter Jan 23, 2025
d5d39e3
add type
alexcarpenter Jan 23, 2025
1f2efb6
add changeset
alexcarpenter Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/neat-jokes-remember.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@clerk/localizations': patch
'@clerk/clerk-js': patch
'@clerk/types': patch
---

Add `subtitleCombined` localizations to sign-in-or-up flow.
25 changes: 17 additions & 8 deletions packages/clerk-js/src/ui/components/SignIn/SignInStart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,14 +429,23 @@ export function _SignInStart(): JSX.Element {
<Card.Root>
<Card.Content>
<Header.Root showLogo>
{isCombinedFlow ? (
<Header.Title localizationKey={localizationKeys('signIn.start.titleCombined')} />
) : (
<>
<Header.Title localizationKey={localizationKeys('signIn.start.title')} />
<Header.Subtitle localizationKey={localizationKeys('signIn.start.subtitle')} />
</>
)}
<Header.Title
localizationKey={
isCombinedFlow ? localizationKeys('signIn.start.titleCombined') : localizationKeys('signIn.start.title')
}
/>
<Header.Subtitle
localizationKey={
isCombinedFlow
? localizationKeys('signIn.start.subtitleCombined')
: localizationKeys('signIn.start.subtitle')
}
sx={{
'&:empty': {
display: 'none',
},
}}
Comment on lines +443 to +447
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default the sign in start subtitle is undefined, and we use the empty selector to ensure the element does not take up any space within the dom. This is to enable folks to see that there is a localization option available for subtitle when viewing source in the dom. Then they can add the localization and it will show for them.

/>
</Header.Root>
<Card.Alert>{card.error}</Card.Alert>
{/*TODO: extract main in its own component */}
Expand Down
8 changes: 7 additions & 1 deletion packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,13 @@ function _SignUpStart(): JSX.Element {
isCombinedFlow ? localizationKeys('signUp.start.titleCombined') : localizationKeys('signUp.start.title')
}
/>
<Header.Subtitle localizationKey={localizationKeys('signUp.start.subtitle')} />
<Header.Subtitle
localizationKey={
isCombinedFlow
? localizationKeys('signUp.start.subtitleCombined')
: localizationKeys('signUp.start.subtitle')
}
/>
</Header.Root>
<Card.Alert>{card.error}</Card.Alert>
<Flex
Expand Down
2 changes: 2 additions & 0 deletions packages/localizations/src/ar-SA.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,6 +459,7 @@ export const arSA: LocalizationResource = {
actionText: 'ليس لديك حساب؟',
actionText__join_waitlist: undefined,
subtitle: 'للمتابعة إلى {{applicationName}}',
subtitleCombined: 'للمتابعة إلى {{applicationName}}',
title: 'تسجيل الدخول',
titleCombined: undefined,
},
Expand Down Expand Up @@ -538,6 +539,7 @@ export const arSA: LocalizationResource = {
actionLink__use_phone: undefined,
actionText: 'لديك حساب بالفعل؟',
subtitle: 'للمتابعة إلى {{applicationName}}',
subtitleCombined: undefined,
title: 'أنشاء حساب جديد',
titleCombined: 'أنشاء حساب جديد',
},
Expand Down
2 changes: 2 additions & 0 deletions packages/localizations/src/be-BY.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,7 @@ export const beBY: LocalizationResource = {
actionText: 'Няма ўліковага запісу?',
actionText__join_waitlist: 'Далучыцеся да чакання',
subtitle: 'каб працягнуць працу ў "{{applicationName}}"',
subtitleCombined: undefined,
title: 'Увайсці',
titleCombined: undefined,
},
Expand Down Expand Up @@ -544,6 +545,7 @@ export const beBY: LocalizationResource = {
actionLink__use_phone: 'Увайсці з дапамогай тэлефона',
actionText: 'Ужо ёсць акаўнт?',
subtitle: 'каб працягнуць працу ў "{{applicationName}}"',
subtitleCombined: 'каб працягнуць працу ў "{{applicationName}}"',
title: 'Стварыце Ваш акаўнт',
titleCombined: 'Стварыце Ваш акаўнт',
},
Expand Down
2 changes: 2 additions & 0 deletions packages/localizations/src/bg-BG.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,6 +459,7 @@ export const bgBG: LocalizationResource = {
actionText: 'Нямате акаунт?',
actionText__join_waitlist: 'Все още нямате акаунт? Присъединете се към листата за изчакване.',
subtitle: 'Добре дошли обратно! Моля, влезте, за да продължите',
subtitleCombined: undefined,
title: 'Влезте в {{applicationName}}',
titleCombined: undefined,
},
Expand Down Expand Up @@ -539,6 +540,7 @@ export const bgBG: LocalizationResource = {
actionLink__use_phone: 'Използвайте телефон',
actionText: 'Вече имате акаунт?',
subtitle: 'Добре дошли! Моля, попълнете данните, за да започнете.',
subtitleCombined: 'Добре дошли! Моля, попълнете данните, за да започнете.',
title: 'Създайте своя акаунт',
titleCombined: 'Създайте своя акаунт',
},
Expand Down
Loading
Loading