fix(clerk-js): Navigate to specific instance for configuration after keyless #5013
Conversation
…for configuration after keyless
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: ccc95c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| ); | ||
| return url.href; | ||
| } catch { | ||
| return ''; |
There was a problem hiding this comment.
Wouldn't it be better to use the last-active path as fallback instead of an empty string?
There was a problem hiding this comment.
this handles the case of the the copyKeysUrl being malformed. I wanted to avoid using dashboad.clerk.com/last-active in general, but maybe i will added it once i have a proper solution to handle dashboard navigations from fapi/worker.
There was a problem hiding this comment.
I see 👍 I guess my point was that after copyKeysUrl is malformed and then also the regex fails, should we have a fallback that "does something" (because empty string won't do anything and the user also doesn't know what's wrong) or should we throw an error? We probably don't want to show an error since it's not actionable (they can't do anything about it) but silently failing is also not nice.
Not familiar with all moving pieces here so I'll trust your judgement :)
There was a problem hiding this comment.
Let's having something more solid and then iterate. I've pushed this
…rectly-to-application
panteliselef
deleted the
elef/actls-71-update-dashboard-link-to-go-directly-to-application
branch
Description
Managing urls to dashboard like that is not sustainable, this will be addressed the following PR, once the flow has been finalized
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change