chore(nextjs): Gracefully handle failure to create keyless #5015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fd9cfd5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
!snapshot |
|
Hey @panteliselef - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/astro@2.1.16-snapshot.v20250127151717 --save-exact
npm i @clerk/backend@1.23.8-snapshot.v20250127151717 --save-exact
npm i @clerk/chrome-extension@2.2.2-snapshot.v20250127151717 --save-exact
npm i @clerk/clerk-js@5.50.0-snapshot.v20250127151717 --save-exact
npm i @clerk/elements@0.22.16-snapshot.v20250127151717 --save-exact
npm i @clerk/clerk-expo@2.7.0-snapshot.v20250127151717 --save-exact
npm i @clerk/expo-passkeys@0.1.15-snapshot.v20250127151717 --save-exact
npm i @clerk/express@1.3.43-snapshot.v20250127151717 --save-exact
npm i @clerk/fastify@2.1.16-snapshot.v20250127151717 --save-exact
npm i @clerk/localizations@3.10.1-snapshot.v20250127151717 --save-exact
npm i @clerk/nextjs@6.10.3-snapshot.v20250127151717 --save-exact
npm i @clerk/nuxt@1.0.12-snapshot.v20250127151717 --save-exact
npm i @clerk/clerk-react@5.22.7-snapshot.v20250127151717 --save-exact
npm i @clerk/react-router@1.0.2-snapshot.v20250127151717 --save-exact
npm i @clerk/remix@4.4.18-snapshot.v20250127151717 --save-exact
npm i @clerk/shared@2.20.15-snapshot.v20250127151717 --save-exact
npm i @clerk/tanstack-start@0.8.17-snapshot.v20250127151717 --save-exact
npm i @clerk/testing@1.4.16-snapshot.v20250127151717 --save-exact
npm i @clerk/themes@2.2.13-snapshot.v20250127151717 --save-exact
npm i @clerk/types@4.44.1-snapshot.v20250127151717 --save-exact
npm i @clerk/ui@0.3.17-snapshot.v20250127151717 --save-exact
npm i @clerk/vue@1.1.7-snapshot.v20250127151717 --save-exact |
jacekradko
reviewed
Jan 27, 2025
|
|
||
| export const ClientClerkProvider = (props: NextClerkProviderProps) => { | ||
| const { children, ...rest } = props; | ||
| export const ClientClerkProvider = (props: NextClerkProviderProps & { disableKeyless?: boolean }) => { |
There was a problem hiding this comment.
Is disableKeyless not an official prop for NextClerkProviderProps?
There was a problem hiding this comment.
No, I only need this in order for the Server Component ClerkProvider to pass it down to the ClientClerkProvider
panteliselef
deleted the
elef/actls-69-implement-a-way-to-turn-off-keyless-in-clerknextjs
branch
wobsoriano
pushed a commit
that referenced
this pull request
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If keys are not explicitly set, keyless will kick in, if keyless creation fails, then fallback to throwing error for missing publishable key
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change