Skip to content

Conversation

@alexcarpenter
Copy link
Member

@alexcarpenter alexcarpenter commented Jan 28, 2025

Description

  • Currently within user profile, you can open both add and remove section forms at once which leads to some awkward UX
  • This PR updates some logic to only be able to render one at a time

BEFORE

Screen.Recording.2025-01-28.at.1.20.40.PM.mov

AFTER

Screen.Recording.2025-01-28.at.1.19.27.PM.mov

Fixes SDKI-817

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel
Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 9:56pm

@changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2025

🦋 Changeset detected

Latest commit: 17a2424

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

const card = useCardState();
const { open } = useActionContext();
const { user } = useUser();
const phoneId = phone.id;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious what the thought behind this assignment is

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A consistent identifier used below to ensure the actions below are scoped to the appropriate phone number.

@LekoArts LekoArts merged commit 68b8917 into main Feb 5, 2025
29 checks passed
@LekoArts LekoArts deleted the alexcarpenter/sdki-817-verify-email-code-ui-remains-in-place-even-if-the-email-is-2 branch February 5, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants