-
Notifications
You must be signed in to change notification settings - Fork 401
feat(clerk-js): Remove web3 providers from sign up continue step #5036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alexcarpenter
merged 6 commits into
main
from
alexcarpenter/sdki-835-okx-wallet-showing-up-on-sign-up-continue
Jan 29, 2025
Merged
feat(clerk-js): Remove web3 providers from sign up continue step #5036
alexcarpenter
merged 6 commits into
main
from
alexcarpenter/sdki-835-okx-wallet-showing-up-on-sign-up-continue
Jan 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 1e670e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
approved these changes
Jan 29, 2025
chanioxaris
approved these changes
Jan 29, 2025
…-on-sign-up-continue
…-continue' of github.com:clerk/javascript into alexcarpenter/sdki-835-okx-wallet-showing-up-on-sign-up-continue
tmilewski
approved these changes
Jan 29, 2025
wobsoriano
pushed a commit
that referenced
this pull request
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
web3 providers cannot be used to fill in missing fields during sign up. This PR removes logic from
SignUpContinuestep that conditionally renders web3 providers from social buttons.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change