Skip to content

Conversation

@alexcarpenter
Copy link
Member

@alexcarpenter alexcarpenter commented Jan 29, 2025

Description

web3 providers cannot be used to fill in missing fields during sign up. This PR removes logic from SignUpContinue step that conditionally renders web3 providers from social buttons.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel
Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 4:24pm

@changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2025

🦋 Changeset detected

Latest commit: 1e670e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexcarpenter alexcarpenter marked this pull request as ready for review January 29, 2025 14:30
@alexcarpenter alexcarpenter requested review from a team and chanioxaris January 29, 2025 14:30
…-continue' of github.com:clerk/javascript into alexcarpenter/sdki-835-okx-wallet-showing-up-on-sign-up-continue
@alexcarpenter alexcarpenter merged commit 1aa5bb6 into main Jan 29, 2025
29 checks passed
@alexcarpenter alexcarpenter deleted the alexcarpenter/sdki-835-okx-wallet-showing-up-on-sign-up-continue branch January 29, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants