fix(tanstack-start): Fix event handler return type mismatch #5051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 0982e00 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wobsoriano
commented
Jan 31, 2025
| "@tanstack/start": "^1.97.25", | ||
| "esbuild-plugin-file-path-extensions": "^2.1.2" | ||
| "esbuild-plugin-file-path-extensions": "^2.1.2", | ||
| "h3": "^1.13.0" |
There was a problem hiding this comment.
Adding to dev deps as we don't use it in runtime. Just need the return type
tmilewski
approved these changes
Jan 31, 2025
wobsoriano
added a commit
that referenced
this pull request
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the handler (
createStartHandler) exposed by@tanstack/start/serverdoesn't match the type expected by our TanStack SDK handler (createClerkHandler). Right now we're usingEventHandlerfromvinxi/httpwhich causes type incompatibility with TanStack's handler that returnsReturnType<typeof eventHandler>fromh3.A key difference is that
eventHandlerfromh3returns a function with overloaded signatures, whileEventHandlerfromvinxi/httpis a simpler type without overloads. This type mismatch creates errors for users trying to pass the handler fromcreateStartHandlerdirectly tocreateClerkHandler.Resolves ECO-353
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change