Skip to content

Conversation

@brkalow
Copy link
Member

@brkalow brkalow commented Jan 31, 2025

Description

Ensures redirect_url parameters passed to Elements components are always passed through build*Url() methods before use. Also updates the methods to accept a params option.

Clerk.buildAfterSignInUrl({ params: new URLSearchParams({ redirect_url: '/dashboard' }) })

fixes SDKI-854

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2025

🦋 Changeset detected

Latest commit: 378311f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@clerk/clerk-js Minor
@clerk/types Minor
@clerk/elements Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/expo-passkeys Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/localizations Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/shared Patch
@clerk/tanstack-start Patch
@clerk/testing Patch
@clerk/themes Patch
@clerk/ui Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 5:44pm

@brkalow brkalow changed the title feat(clerk-js,elements): pass redirect_url through build*Url() methods feat(clerk-js,elements): Pass redirect_url through build*Url() methods Jan 31, 2025
@brkalow brkalow changed the title feat(clerk-js,elements): Pass redirect_url through build*Url() methods feat(clerk-js,elements): Pass params through build*Url() methods Jan 31, 2025
@brkalow brkalow marked this pull request as ready for review January 31, 2025 17:12
@brkalow brkalow requested a review from a team January 31, 2025 17:14
@brkalow brkalow merged commit d3152be into main Jan 31, 2025
31 checks passed
@brkalow brkalow deleted the brk.feat/redirect-url-for-build branch January 31, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants