chore(clerk-js): Add virtual routing deprecation warning #5072
Conversation
🦋 Changeset detectedLatest commit: 9e76956 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
!snapshot |
|
Hey @alexcarpenter - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/chrome-extension@2.2.6-snapshot.v20250203181640 --save-exact
npm i @clerk/clerk-js@5.51.1-snapshot.v20250203181640 --save-exact
npm i @clerk/clerk-expo@2.7.4-snapshot.v20250203181640 --save-exact
npm i @clerk/tanstack-start@0.9.3-snapshot.v20250203181640 --save-exact |
| if (props.componentProps.routing === 'virtual') { | ||
| deprecated('routing="virtual"', 'Use routing="hash" instead.'); | ||
| } |
There was a problem hiding this comment.
Asking for confirmation here, since this is only logged in LazyComponentRenderer, it means that SignInModal will not display the deprecation, but if someone does <SignIn routing="virtual" /> then it will.
There was a problem hiding this comment.
From my testing, that is correct.
LekoArts
deleted the
alexcarpenter/sdki-803-drop-routing-virtual-from-types-2
branch
Description
Adding a deprecation warning for virtual routing usage, that is to be removed in the next major release.
Resolves SDKI-858
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change