fix(clerk-js): Correctly show alternative re-verification methods #5164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 11c231e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/clerk-js/src/ui/components/UserVerification/AlternativeMethods.tsx
Outdated
Show resolved
Hide resolved
octoper
commented
Feb 19, 2025
packages/clerk-js/src/ui/components/UserVerification/AlternativeMethods.tsx
Outdated
Show resolved
Hide resolved
octoper
force-pushed
the
vaggelis/user-1294-alternative-verification-methods-on-modal-are-not-showing-up
branch
from
419acdf to
8f6cfb8
Compare
packages/clerk-js/src/ui/components/UserVerification/UVFactorOneCodeForm.tsx
Outdated
Show resolved
Hide resolved
| }; | ||
|
|
||
| const hasAlternativeStrategies = | ||
| (availableFactors && availableFactors.filter(factor => isDeeplyEqual(factor, currentFactor)).length > 0) || false; |
There was a problem hiding this comment.
Is isDeeplyEqual necessary ? It could be an expensive operation for every render
There was a problem hiding this comment.
This could be simplified by checking the id for each strategy, will create a utility helper to check this.
There was a problem hiding this comment.
this still uses isDeeplyEqual, is this intentional ?
There was a problem hiding this comment.
Ops, this is a leftover 🙃
octoper
force-pushed
the
vaggelis/user-1294-alternative-verification-methods-on-modal-are-not-showing-up
branch
from
7cddc3b to
a8a8982
Compare
octoper
force-pushed
the
vaggelis/user-1294-alternative-verification-methods-on-modal-are-not-showing-up
branch
from
a8a8982 to
ae5afe2
Compare
octoper
force-pushed
the
vaggelis/user-1294-alternative-verification-methods-on-modal-are-not-showing-up
branch
from
ae5afe2 to
f8cc295
Compare
octoper
changed the title
panteliselef
approved these changes
Feb 25, 2025
| }; | ||
|
|
||
| const hasAlternativeStrategies = | ||
| (availableFactors && availableFactors.filter(factor => isDeeplyEqual(factor, currentFactor)).length > 0) || false; |
There was a problem hiding this comment.
this still uses isDeeplyEqual, is this intentional ?
octoper
force-pushed
the
vaggelis/user-1294-alternative-verification-methods-on-modal-are-not-showing-up
branch
from
f8cc295 to
914543a
Compare
octoper
force-pushed
the
vaggelis/user-1294-alternative-verification-methods-on-modal-are-not-showing-up
branch
from
09dc701 to
5232ca7
Compare
octoper
force-pushed
the
vaggelis/user-1294-alternative-verification-methods-on-modal-are-not-showing-up
branch
from
5232ca7 to
febd7d5
Compare
octoper
force-pushed
the
vaggelis/user-1294-alternative-verification-methods-on-modal-are-not-showing-up
branch
from
febd7d5 to
9dced53
Compare
chanioxaris
approved these changes
Mar 7, 2025
octoper
force-pushed
the
vaggelis/user-1294-alternative-verification-methods-on-modal-are-not-showing-up
branch
from
9254503 to
11c231e
Compare
octoper
deleted the
vaggelis/user-1294-alternative-verification-methods-on-modal-are-not-showing-up
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue with alternative method on the user re-verification modal that was shown incorrectly in specific cases like when there was not alternative method we still showed the button to go to the alternative methods screen, or like another case where we hid alternative methods that had the same strategy but they were different.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change