Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/spotty-schools-juggle.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@clerk/nextjs': patch
'@clerk/astro': patch
'@clerk/nuxt': patch
---

Remove telemtry event from `clerkMiddleware()`.
9 changes: 0 additions & 9 deletions packages/astro/src/server/clerk-middleware.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import type { AuthenticateRequestOptions, ClerkRequest, RedirectFun, RequestStat
import { AuthStatus, constants, createClerkRequest, createRedirect } from '@clerk/backend/internal';
import { isDevelopmentFromPublishableKey, isDevelopmentFromSecretKey } from '@clerk/shared/keys';
import { isHttpOrHttps } from '@clerk/shared/proxy';
import { eventMethodCalled } from '@clerk/shared/telemetry';
import { handleValueOrFn } from '@clerk/shared/utils';
import type { APIContext } from 'astro';

Expand Down Expand Up @@ -68,14 +67,6 @@ export const clerkMiddleware: ClerkMiddleware = (...args: unknown[]): any => {

const clerkRequest = createClerkRequest(context.request);

clerkClient(context).telemetry.record(
eventMethodCalled('clerkMiddleware', {
handler: Boolean(handler),
satellite: Boolean(options.isSatellite),
proxy: Boolean(options.proxyUrl),
}),
);

const requestState = await clerkClient(context).authenticateRequest(
clerkRequest,
createAuthenticateRequestOptions(clerkRequest, options, context),
Expand Down
9 changes: 0 additions & 9 deletions packages/nextjs/src/server/clerkMiddleware.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import type { AuthObject, ClerkClient } from '@clerk/backend';
import type { AuthenticateRequestOptions, ClerkRequest, RedirectFun, RequestState } from '@clerk/backend/internal';
import { AuthStatus, constants, createClerkRequest, createRedirect } from '@clerk/backend/internal';
import { eventMethodCalled } from '@clerk/shared/telemetry';
import { notFound as nextjsNotFound } from 'next/navigation';
import type { NextMiddleware, NextRequest } from 'next/server';
import { NextResponse } from 'next/server';
Expand Down Expand Up @@ -128,14 +127,6 @@ export const clerkMiddleware = ((...args: unknown[]): NextMiddleware | NextMiddl
clerkMiddlewareRequestDataStore.set('requestData', options);
const resolvedClerkClient = await clerkClient();

resolvedClerkClient.telemetry.record(
eventMethodCalled('clerkMiddleware', {
handler: Boolean(handler),
satellite: Boolean(options.isSatellite),
proxy: Boolean(options.proxyUrl),
}),
);

if (options.debug) {
logger.enable();
}
Expand Down
9 changes: 0 additions & 9 deletions packages/nuxt/src/runtime/server/clerkMiddleware.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import type { AuthenticateRequestOptions } from '@clerk/backend/internal';
import { AuthStatus, constants } from '@clerk/backend/internal';
import { eventMethodCalled } from '@clerk/shared/telemetry';
import type { EventHandler } from 'h3';
import { createError, eventHandler, setResponseHeader } from 'h3';

Expand Down Expand Up @@ -80,14 +79,6 @@ export const clerkMiddleware: ClerkMiddleware = (...args: unknown[]) => {
return eventHandler(async event => {
const clerkRequest = toWebRequest(event);

clerkClient(event).telemetry.record(
eventMethodCalled('clerkMiddleware', {
handler: Boolean(handler),
satellite: Boolean(options.isSatellite),
proxy: Boolean(options.proxyUrl),
}),
);

const requestState = await clerkClient(event).authenticateRequest(clerkRequest, options);

const locationHeader = requestState.headers.get(constants.Headers.Location);
Expand Down