Skip to content

Conversation

@alexcarpenter
Copy link
Member

Description

Resolves SDKI-974

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel
Copy link

vercel bot commented Apr 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 8:23pm

@changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2025

🦋 Changeset detected

Latest commit: 5434444

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexcarpenter alexcarpenter changed the title chore(clerk-js): update secured by clerk link chore(clerk-js): Update secured by clerk link URL Apr 1, 2025
@alexcarpenter alexcarpenter requested a review from a team April 1, 2025 20:22
return (
<Link
href='https://www.clerk.com?utm_source=clerk&utm_medium=components'
href='https://go.clerk.com/components'
Copy link
Member

@dstaley dstaley Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just confirming that we're okay losing the UTM parameters here? I assume the go subdomain is doing some sort of analytics tracking so it's okay?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the go url contains the utm params.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @alexcarpenter

@LekoArts LekoArts merged commit 6fcd93c into main Apr 2, 2025
32 checks passed
@LekoArts LekoArts deleted the alexcarpenter/sdki-974-swap-the-existing-link-for-components-2 branch April 2, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants