fix(clerk-js): Incremental improvements for account funds #5705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes CLS issues when rendering account funds - Renames "accounts funds" to "payment sources" for consistency - Auto opes the "Add a new payment source" drawer only if no payments sources exist
🦋 Changeset detectedLatest commit: a2e5343 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
panteliselef
commented
Apr 24, 2025
Comment on lines
+34
to
+42
| useFetch( | ||
| __experimental_commerce?.getPaymentSources, | ||
| { | ||
| ...(subscriberType === 'org' ? { orgId: organization?.id } : {}), | ||
| }, | ||
| undefined, | ||
| 'commerce-payment-sources', | ||
| ); | ||
|
|
There was a problem hiding this comment.
basically prefetching from pricing table in order to avoid the layout shift.
| > | ||
| {/* TODO(@Commerce): needs localization */} | ||
| <Disclosure.Trigger text='Account Funds' /> | ||
| <Disclosure.Trigger text='Payment Sources' /> |
There was a problem hiding this comment.
In follow up ticket we will be handling localization for Checkout.
aeliox
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change