Skip to content

fix(clerk-js): Revalidate payment sources from <Checkout /> #5709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2025
Merged

fix(clerk-js): Revalidate payment sources from <Checkout /> #5709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
051c4b4
fix(clerk-js): Revalidate payment sources from `<Checkout />`
panteliselef Apr 24, 2025
c8bc41d
fix(clerk-js): Revalidate payment sources from `<Checkout />`
panteliselef Apr 24, 2025
9009117
Merge branch 'main' into elef/com-557-revalidate-payment-sources-afte…
panteliselef Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fluffy-snails-sort.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Revalidate payment sources from `<Checkout />` when a new payment source is added before the checkout is completed.
12 changes: 12 additions & 0 deletions packages/clerk-js/src/ui/components/PaymentSources/AddPaymentSource.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,16 @@ const AddPaymentSourceForm = withCardStateProvider(
const { subscriberType } = usePaymentSourcesContext();
const [submitError, setSubmitError] = useState<ClerkRuntimeError | ClerkAPIError | string | undefined>();

// Revalidates the next time the hooks gets mounted
const { revalidate } = useFetch(
undefined,
{
...(subscriberType === 'org' ? { orgId: organization?.id } : {}),
},
undefined,
'commerce-payment-sources',
);

const onSubmit = async (e: React.FormEvent<HTMLFormElement>) => {
e.preventDefault();
if (!stripe || !elements) {
Expand All @@ -167,6 +177,8 @@ const AddPaymentSourceForm = withCardStateProvider(
...(subscriberType === 'org' ? { orgId: organization?.id } : {}),
});

revalidate();

void onSuccess(paymentSource);
} catch (error) {
void handleError(error, [], setSubmitError);
Expand Down