-
Couldn't load subscription status.
- Fork 402
feat(clerk-js): Display proration in <Checkout />
#5746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clerk-js): Display proration in <Checkout />
#5746
Conversation
🦋 Changeset detectedLatest commit: e9e1b9a The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| sx={t => ({ | ||
| display: 'inline-flex', | ||
| justifyContent: 'flex-end', | ||
| alignItems: 'center', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why'd we remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <LineItems.Group> | ||
| {showDowngradeInfo && ( | ||
| <LineItems.Group expand> | ||
| <LineItems.Title description={'Your features will remain the end of your current subscription.'} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should fetch the active subscription and grab the plan name and period end date to make this line more informative – eg Your Silver plan features will remain until April 1st, 2025.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FAPI changes are tracked here
| )} | ||
|
|
||
| <LineItems.Group borderTop={showDowngradeInfo}> | ||
| <LineItems.Title title={plan.name} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be great to show this in the Total Due [Starting date] with the amount they will be charged. But again, i think the checkout create payload will need to update to reflect that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes a good case for the difference between grandTotal and totalDueNow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm waiting on the FAPI endpoints to be updated, I don't know when that will be. I'm using whatever is available at the moment.



Description
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change