feat(backend): Initial handshake nonce pre-work #5750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0d92d37 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jacekradko
commented
Apr 29, 2025
jacekradko
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the initial handshake nonce pre-work and refactors parts of the handshake flow. Key changes include:
- Adding new types and constants to support organization sync target matching and handshake nonce handling.
- Refactoring the handshake logic by introducing the HandshakeService and updating request and authentication context handling.
- Adding new API resources, endpoints, and tests for the handshake payload flow.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/backend/src/tokens/types.ts | Added definitions for OrganizationSyncTargetMatchers and OrganizationSyncTarget. |
| packages/backend/src/tokens/request.ts | Updated request handling to leverage methods from HandshakeService. |
| packages/backend/src/tokens/handshake.ts | Introduced HandshakeService with methods to handle handshake flow including nonce handling (stubbed). |
| packages/backend/src/tokens/authenticateContext.ts | Extended context to include handshakeNonce from query params and cookies. |
| packages/backend/src/api/resources/HandshakePayload.ts | Added handshake payload resource model. |
| packages/backend/src/api/endpoints/HandshakePayloadApi.ts | New API endpoint for retrieving handshake payload. |
| packages/backend/src/constants.ts | Added handshakeNonce constant to cookies and query parameters. |
| packages/backend/src/tokens/tests/handshake.test.ts | Created tests to validate HandshakeService behavior. |
| .changeset/better-vans-obey.md | Changeset file to document the new handshake payload flow changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial stub of the handshake nonce flow. Implementation will be in a separate PR
Related: SDKI-979
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change