Skip to content

chore(clerk-js): Adjust the checkout line item rows #5804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 2, 2025
Merged

chore(clerk-js): Adjust the checkout line item rows #5804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e12af1
chore(clerk-js): Adjust the checkout line item rows
aeliox May 2, 2025
d4e538b
changeset
aeliox May 2, 2025
4dd12f8
copy tweak
aeliox May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/stupid-animals-taste.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Adjusts the order and layout of the checkout form's line items
9 changes: 0 additions & 9 deletions packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,15 +130,6 @@ export const CheckoutComplete = ({ checkout }: { checkout: __experimental_Commer
}
/>
</LineItems.Group>
<LineItems.Group variant='tertiary'>
<LineItems.Title title={localizationKeys('__experimental_commerce.checkout.lineItems.title__invoiceId')} />
<LineItems.Description
text={checkout.invoice_id || '–'}
truncateText
copyText
copyLabel='Copy invoice ID'
/>
</LineItems.Group>
</LineItems.Root>
<Button
onClick={handleClose}
Expand Down
28 changes: 10 additions & 18 deletions packages/clerk-js/src/ui/components/Checkout/CheckoutForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,33 +67,25 @@ export const CheckoutForm = ({
suffix={`per month${planPeriod === 'annual' ? ', times 12 months' : ''}`}
/>
</LineItems.Group>
<LineItems.Group
borderTop
variant='tertiary'
>
{/* TODO(@Commerce): needs localization */}
<LineItems.Title title='Subtotal' />
<LineItems.Description text={`${totals.subtotal.currencySymbol}${totals.subtotal.amountFormatted}`} />
</LineItems.Group>
{showCredits && (
<LineItems.Group>
<LineItems.Group variant='tertiary'>
{/* TODO(@Commerce): needs localization */}
<LineItems.Title
title={'Credit'}
description={'Prorated credit for the remainder of your subscription.'}
/>
<LineItems.Title title={'Credit for the remainder of your current subscription.'} />
{/* TODO(@Commerce): needs localization */}
{/* TODO(@Commerce): Replace client-side calculation with server-side calculation once data are available in the response */}
<LineItems.Description
text={`- ${totals.proration?.credit.currencySymbol}${totals.proration?.credit.amountFormatted}`}
/>
</LineItems.Group>
)}
<LineItems.Group
borderTop
variant='tertiary'
>
{/* TODO(@Commerce): needs localization */}
<LineItems.Title title='Subtotal' />
<LineItems.Description text={`${totals.subtotal.currencySymbol} ${totals.subtotal.amountFormatted}`} />
</LineItems.Group>
<LineItems.Group variant='tertiary'>
{/* TODO(@Commerce): needs localization */}
<LineItems.Title title='Tax' />
<LineItems.Description text={`${totals.taxTotal.currencySymbol} ${totals.taxTotal.amountFormatted}`} />
</LineItems.Group>
<LineItems.Group borderTop>
{/* TODO(@Commerce): needs localization */}
<LineItems.Title title={`Total Due Today`} />
Expand Down