-
Couldn't load subscription status.
- Fork 403
feat(types,clerk-js): Add oidcPrompt prop to SignIn/SignUp components
#5925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 221127c The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
3eaa255 to
2a52afd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read through this in it's entirety and walked through it with @LauraBeatris , and it makes sense to me! I think we should merge it.
ea927db to
221127c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me! I think we can improve the DX a little bit on the oidcPrompt param by adding a set of allowed values
export type OIDCPrompt = 'none' | 'login' | 'consent' | 'select_account';
@NicolasLopes7 I'm a little hesitant about it since the OIDC spec could change - they would rarely rename those values, but keeping a wide string type avoids having to release new changes or keep track of the spec itself. |
Description
Resolves ORGS-647
Add
oidcPromptprop toSignInandSignUpcomponents andauthenticateWithRedirectmethod to control the OIDC authentication prompt behavior during Enterprise SSO flows.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change