Skip to content

Conversation

@LauraBeatris
Copy link
Member

@LauraBeatris LauraBeatris commented May 14, 2025

Description

Resolves ORGS-647

Add oidcPrompt prop to SignIn and SignUp components and authenticateWithRedirect method to control the OIDC authentication prompt behavior during Enterprise SSO flows.

<SignUp oidcPrompt='select_account' /> 
<SignIn oidcPrompt='select_account' /> 
signUp.authenticateWithRedirect({ redirectUrl: '/sso-callback', oidcPrompt: 'select_account' })

CleanShot 2025-05-14 at 15 57 44

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented May 14, 2025

🦋 Changeset detected

Latest commit: 221127c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@clerk/clerk-js Patch
@clerk/types Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/agent-toolkit Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/elements Patch
@clerk/expo-passkeys Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/localizations Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/shared Patch
@clerk/tanstack-react-start Patch
@clerk/testing Patch
@clerk/themes Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2025 7:23pm

Copy link
Contributor

@izaaklauer izaaklauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read through this in it's entirety and walked through it with @LauraBeatris , and it makes sense to me! I think we should merge it.

Copy link
Contributor

@NicolasLopes7 NicolasLopes7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me! I think we can improve the DX a little bit on the oidcPrompt param by adding a set of allowed values

export type OIDCPrompt = 'none' | 'login' | 'consent' | 'select_account';

@LauraBeatris
Copy link
Member Author

Changes looks good to me! I think we can improve the DX a little bit on the oidcPrompt param by adding a set of allowed values

export type OIDCPrompt = 'none' | 'login' | 'consent' | 'select_account';

@NicolasLopes7 I'm a little hesitant about it since the OIDC spec could change - they would rarely rename those values, but keeping a wide string type avoids having to release new changes or keep track of the spec itself.

@LauraBeatris LauraBeatris merged commit 65f0878 into main May 14, 2025
32 checks passed
@LauraBeatris LauraBeatris deleted the laura/set-oidc-prompt-enterprise-sso branch May 14, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants