Skip to content

Conversation

@tmilewski
Copy link
Member

Description

Handles missing publicUserData for OrganizationMemberships if it's undefined

Fixes ECO-658
Fixes #6010

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@tmilewski tmilewski self-assigned this May 27, 2025
@changeset-bot
Copy link

changeset-bot bot commented May 27, 2025

🦋 Changeset detected

Latest commit: a1d4c47

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@clerk/clerk-js Patch
@clerk/types Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/agent-toolkit Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/elements Patch
@clerk/expo-passkeys Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/localizations Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/shared Patch
@clerk/tanstack-react-start Patch
@clerk/testing Patch
@clerk/themes Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2025 11:17pm

@pkg-pr-new
Copy link

pkg-pr-new bot commented May 27, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6016

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6016

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6016

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6016

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6016

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6016

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6016

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6016

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6016

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6016

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6016

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6016

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6016

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6016

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6016

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6016

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6016

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6016

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6016

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6016

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6016

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6016

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6016

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6016

commit: a1d4c47

};

update = async ({ role }: UpdateOrganizationMembershipParams): Promise<OrganizationMembership> => {
// TODO: Handle case where publicUserData is not present
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the todo's needed ?

@tmilewski tmilewski merged commit 71e6a1f into main May 28, 2025
36 checks passed
@tmilewski tmilewski deleted the tm/eco-658-org-membership-to-snapshot branch May 28, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property '__internal_toSnapshot' of undefined when using __experimental_resourceCache in ClerkProvider (Expo App Offline Support)

4 participants