chore(localizations): Update german text for waitlists #6631
Conversation
Update german text for waitlists
🦋 Changeset detectedLatest commit: ed134d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@okikeSolutions is attempting to deploy a commit to the Clerk Production Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughRevised German (de-DE) localization strings for the waitlist start and success flows: action labels, form button text, the start subtitle, and the success message were updated; keys, file structure, and exports remain unchanged. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/localizations/src/de-DE.ts (1)
1301-1304: Polish German phrasing for clarity and consistencyMinimal changes (keep existing “Warteliste beitreten” labels):
--- packages/localizations/src/de-DE.ts +++ packages/localizations/src/de-DE.ts @@ Lines 1301–1304 - actionText: 'Bereits Zugang?', + actionText: 'Haben Sie bereits Zugang?' - subtitle: 'Geben Sie Ihre E-Mail-Adresse ein und wir benachrichtigen Sie, sobald Ihr Zugang verfügbar ist.', + subtitle: 'Geben Sie Ihre E-Mail-Adresse ein und wir benachrichtigen Sie, sobald der Zugang verfügbar ist.',Optional stricter-grammar variant (update all “Warteliste beitreten” occurrences to dative “der Warteliste beitreten”):
• actionLink__join_waitlist (line 702)
• actionText__join_waitlist (line 709)
• blockButton__joinWaitlist (line 793)
• formButton (line 1303)--- packages/localizations/src/de-DE.ts +++ packages/localizations/src/de-DE.ts @@ actionLink__join_waitlist (≈702) - actionLink__join_waitlist: 'Warteliste beitreten', + actionLink__join_waitlist: 'Der Warteliste beitreten', @@ actionText__join_waitlist (≈709) - actionText__join_waitlist: 'Warteliste beitreten', + actionText__join_waitlist: 'Der Warteliste beitreten', @@ blockButton__joinWaitlist (≈793) - blockButton__joinWaitlist: 'Warteliste beitreten', + blockButton__joinWaitlist: 'Der Warteliste beitreten', @@ formButton (≈1303) - formButton: 'Warteliste beitreten', + formButton: 'Der Warteliste beitreten',Applying this variant ensures strict grammatical accuracy (dative case) but requires sweeping updates in this and potentially other locale files. Please review for consistency if you opt in.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
packages/localizations/src/de-DE.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (7)
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
**/*.{js,jsx,ts,tsx}: All code must pass ESLint checks with the project's configuration
Follow established naming conventions (PascalCase for components, camelCase for variables)
Maintain comprehensive JSDoc comments for public APIs
Use dynamic imports for optional features
All public APIs must be documented with JSDoc
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Profile and optimize critical paths
Validate all inputs and sanitize outputs
Implement proper logging with different levels
Files:
packages/localizations/src/de-DE.ts
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use Prettier for consistent code formatting
Files:
packages/localizations/src/de-DE.ts
packages/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
TypeScript is required for all packages
Files:
packages/localizations/src/de-DE.ts
packages/**/*.{ts,tsx,d.ts}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Packages should export TypeScript types alongside runtime code
Files:
packages/localizations/src/de-DE.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use proper TypeScript error types
**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoidanytype - preferunknownwhen type is uncertain, then narrow with type guards
Useinterfacefor object shapes that might be extended
Usetypefor unions, primitives, and computed types
Preferreadonlyproperties for immutable data structures
Useprivatefor internal implementation details
Useprotectedfor inheritance hierarchies
Usepublicexplicitly for clarity in public APIs
Preferreadonlyfor properties that shouldn't change after construction
Prefer composition and interfaces over deep inheritance chains
Use mixins for shared behavior across unrelated classes
Implement dependency injection for loose coupling
Let TypeScript infer when types are obvious
Useconst assertionsfor literal types:as const
Usesatisfiesoperator for type checking without widening
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Use type-only imports:import type { ... } from ...
Noanytypes without justification
Proper error handling with typed errors
Consistent use ofreadonlyfor immutable data
Proper generic constraints
No unused type parameters
Proper use of utility types instead of manual type construction
Type-only imports where possible
Proper tree-shaking friendly exports
No circular dependencies
Efficient type computations (avoid deep recursion)
Files:
packages/localizations/src/de-DE.ts
packages/localizations/**/*
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Localization files must be placed in 'packages/localizations/'.
Files:
packages/localizations/src/de-DE.ts
**/*.{js,ts,tsx,jsx}
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Support multiple Clerk environment variables (CLERK_, NEXT_PUBLIC_CLERK_, etc.) for configuration.
Files:
packages/localizations/src/de-DE.ts
There was a problem hiding this comment.
Thank you. Can you also add a changeset for this one? Similar to 479da36
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.changeset/empty-cameras-judge.md (2)
5-5: Prefer imperative voice in the summary line.Minor style tweak for consistency with common Changeset conventions.
-Refined German (de-DE) waitlist localization for improved clarity and consistency +Refine German (de-DE) waitlist localization for improved clarity and consistency
8-12: Use code spans for literal strings and align terminology (“success message”).Improves readability and avoids curly-quote issues in terminals; “success message” matches the key name better than “success subtitles.”
-- Updating action link text from “Jetzt anmelden” to “Anmelden” -- Changing action text from “Kein Zugang? Auf die Warteliste setzen!” to “Bereits Zugang?” -- Adjusting form button label from “Zur Warteliste hinzufügen” to “Warteliste beitreten” +- Updating action link text from `Jetzt anmelden` to `Anmelden` +- Changing action text from `Kein Zugang? Auf die Warteliste setzen!` to `Bereits Zugang?` +- Adjusting form button label from `Zur Warteliste hinzufügen` to `Warteliste beitreten` - Clarifying the waitlist start subtitle with instructions to enter an email for notifications -- Aligning success subtitles with consistent wording for availability notifications +- Aligning success message wording for availability notifications
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.changeset/empty-cameras-judge.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Automated releases must use Changesets.
Files:
.changeset/empty-cameras-judge.md
🪛 LanguageTool
.changeset/empty-cameras-judge.md
[grammar] ~10-~10: There might be a mistake here.
Context: ...teliste setzen!” to “Bereits Zugang?” - Adjusting form button label from “Zur Warteliste ...
(QB_NEW_EN)
[grammar] ~10-~10: There might be a mistake here.
Context: ...te hinzufügen” to “Warteliste beitreten” - Clarifying the waitlist start subtitle w...
(QB_NEW_EN)
[grammar] ~11-~11: There might be a mistake here.
Context: ...ions to enter an email for notifications - Aligning success subtitles with consiste...
(QB_NEW_EN)
🔇 Additional comments (2)
.changeset/empty-cameras-judge.md (2)
1-4: Changeset frontmatter looks correct (package + patch).Targets '@clerk/localizations' with a patch bump as expected for copy updates.
7-14: Verify German waitlist copy in de-DE.tsI’ve confirmed the updated strings in
packages/localizations/src/de-DE.tsunder thewaitlist.startsection:– actionText: 'Kein Zugang? Auf die Warteliste setzen!' + actionText: 'Bereits Zugang?' actionLink: 'Anmelden' formButton: 'Warteliste beitreten' subtitle: 'Geben Sie Ihre E-Mail-Adresse ein und wir benachrichtigen Sie, sobald Ihr Zugang verfügbar ist.'• The change from “Kein Zugang? Auf die Warteliste setzen!” to “Bereits Zugang?” shifts the prompt from “Don’t have access? Join the waitlist!” to “Already have access?”, which could confuse the intended call-to-action.
• Please verify with the UX/copy team that “Bereits Zugang?” correctly conveys the desired intent and aligns with product guidance before shipping.
wobsoriano
changed the title
4 participants
Update german text for waitlists
Description
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit