Skip to content

chore(clerk-js): Remove unused pieces #6636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 29, 2025
Merged

chore(clerk-js): Remove unused pieces #6636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
30539bc
chore(clerk-js): Remove unused pieces
panteliselef Aug 26, 2025
6c4f41b
update typedocs
panteliselef Aug 26, 2025
6ab027b
fix linting
panteliselef Aug 26, 2025
d17e247
remove commerce product
panteliselef Aug 29, 2025
6803a8e
Merge branch 'main' into elef/clerk-js-cleanup
panteliselef Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/long-owls-yawn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
Comment on lines +1 to +2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Empty changeset will fail release automation — fill in package and bump type or remove the file

The file only contains frontmatter delimiters. Changesets expects at least one package with a bump type and a short summary. Given this PR removes/privatizes exports, please either mark as "none" (if truly no public surface change) or "patch/minor" with a clear note.

Apply one of the following:

Option A — publish a patch (replace PACKAGE_NAME after verifying from packages/clerk-js/package.json):

---- 
----
+---
+'PACKAGE_NAME': patch
+---
+
+chore(clerk-js): remove unused internal pieces and privatize non-public helpers. No public API changes.

Option B — no release (documentation-only/internal cleanup):

----
----
+---
+'PACKAGE_NAME': none
+---
+
+Internal cleanup: remove unused pieces and privatize helpers (no public API changes).

Run to confirm the actual package name and whether any removed symbols were part of the public export map:

🏁 Script executed:

#!/bin/bash
# Find package name
cat packages/clerk-js/package.json | jq -r '.name,.exports'

# Check if removed/privatized symbols were publicly exported (should return no matches)
rg -nP -C2 "(export\\s+\\*\\s+from\\s+['\"]/ui/(elements|hooks)/|CommerceProduct|CommerceProductJSON|useCache\\b|ReversibleContainer\\b|getPlatform\\b|fileToBase64\\b)" packages/clerk-js

Length of output: 6399

🏁 Script executed:

#!/bin/bash
# Inspect package.json entry points for clerk-js
echo "package.json entry points:"
jq '{main, module, types, exports}' packages/clerk-js/package.json

echo
# Locate any index.ts files in the clerk-js package
echo "Index files:"
fd --type f index.ts packages/clerk-js

echo
# Print the first 50 lines of each index.ts to see what is publicly re-exported
for file in $(fd --type f index.ts packages/clerk-js); do
  echo "==> $file <=="
  head -n 50 "$file"
  echo
done

Length of output: 66782

🏁 Script executed:

#!/bin/bash
# Inspect package.json for entry points
echo "Package entry points:"
jq '.name, .main, .module, .types, .exports' packages/clerk-js/package.json

echo
# Search public index.ts exports for removed symbols
echo "Searching public exports for removed symbols:"
rg -nP 'fileToBase64|ReversibleContainer|useCache|getPlatform|CommerceProduct|CommerceProductJSON' -g 'packages/clerk-js/src/**/index.ts' -n

Length of output: 462

Fill in bump type for @clerk/clerk-js
The current changeset file (.changeset/long-owls-yawn.md) is empty and will break the release automation. Since none of the removed symbols are part of the public API, please mark this as a “none” release.

• File needing update:

  • .changeset/long-owls-yawn.md

• Replace its contents with:

---
'@clerk/clerk-js': none
---

Internal cleanup: remove unused internal pieces and privatize non-public helpers (no public API changes).
🧰 Tools
🪛 LanguageTool

[grammar] ~1-~1: Hier könnte ein Fehler sein.
Context: --- ---

(QB_NEW_DE)

🤖 Prompt for AI Agents 
In .changeset/long-owls-yawn.md around lines 1-2 the file is empty which will
break release automation; replace the file contents with a changeset that sets
'@clerk/clerk-js' to "none" and includes the provided rationale line ("Internal
cleanup: remove unused internal pieces and privatize non-public helpers (no
public API changes).") so the changeset YAML is valid and marks this as a none
release.

5 changes: 5 additions & 0 deletions .changeset/nice-apes-vanish.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/types': minor
---

[Billing Beta] Remove CommerceProduct.
2 changes: 0 additions & 2 deletions .typedoc/__tests__/__snapshots__/file-structure.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@ exports[`Typedoc output > should have a deliberate file structure 1`] = `
"types/commerce-payment-status.mdx",
"types/commerce-plan-json.mdx",
"types/commerce-plan-resource.mdx",
"types/commerce-product-json.mdx",
"types/commerce-product-resource.mdx",
"types/commerce-statement-group-json.mdx",
"types/commerce-statement-group.mdx",
"types/commerce-statement-json.mdx",
Expand Down
30 changes: 0 additions & 30 deletions packages/clerk-js/src/core/resources/CommerceProduct.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/clerk-js/src/core/resources/internal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ export * from './CommerceStatement';
export * from './CommercePayment';
export * from './CommercePaymentSource';
export * from './CommercePlan';
export * from './CommerceProduct';
export * from './CommerceSubscription';
export * from './DeletedObject';
export * from './DisplayConfig';
Expand Down
40 changes: 0 additions & 40 deletions packages/clerk-js/src/ui/common/BlockButtons.tsx
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/clerk-js/src/ui/common/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
export * from './BlockButtons';
export * from './CalloutWithAction';
export * from './constants';
export * from './EmailLinkStatusCard';
Expand Down
1 change: 0 additions & 1 deletion packages/clerk-js/src/ui/components/UserProfile/UserProfileBlockButtons.tsx
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/clerk-js/src/ui/elements/AvatarUploader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export type AvatarUploaderProps = {
avatarPreviewPlaceholder?: React.ReactElement | null;
};

export const fileToBase64 = (file: File): Promise<string> => {
const fileToBase64 = (file: File): Promise<string> => {
return new Promise((resolve, reject) => {
const reader = new FileReader();
reader.readAsDataURL(file);
Expand Down
69 changes: 0 additions & 69 deletions packages/clerk-js/src/ui/elements/BlockWithTrailingComponent.tsx
View file
Open in desktop

This file was deleted.

190 changes: 0 additions & 190 deletions packages/clerk-js/src/ui/elements/Disclosure.tsx
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions packages/clerk-js/src/ui/elements/FormControl.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import type { ThemableCssProp } from '../styledSystem';
import { animations } from '../styledSystem';
import type { FeedbackType, useFormControlFeedback } from '../utils/useFormControl';

export function useFormTextAnimation() {
function useFormTextAnimation() {
const prefersReducedMotion = usePrefersReducedMotion();
const { animations: appearanceAnimations } = useAppearance().parsedLayout;

Expand Down Expand Up @@ -48,7 +48,7 @@ export function useFormTextAnimation() {
};
}

export const useCalculateErrorTextHeight = ({ feedback }: { feedback: string }) => {
const useCalculateErrorTextHeight = ({ feedback }: { feedback: string }) => {
const [height, setHeight] = useState(0);

const calculateHeight = useCallback(
Expand Down
Loading
Loading