chore(localizations): Update account deletion confirmation copy #6937
Conversation
🦋 Changeset detectedLatest commit: 917f713 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughUpdated delete-account confirmation copy across localization files to a generic phrasing that asks to confirm account deletion, notes some associated data may be retained, and instructs users to contact support to request full data deletion. No API, control-flow, or logic changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🧹 Nitpick comments (3)
packages/localizations/src/hr-HR.ts (1)
1040-1040: Polish the Croatian wording for messageLine1Current phrasing “Za zahtjev potpunog brisanja podataka, molimo kontaktirajte podršku.” sounds awkward in Croatian. Please consider a more natural construction like “Zahtjev za potpuno brisanje podataka pošaljite podršci.” to keep the localization idiomatic while preserving the intent.
- 'Jeste li sigurni da želite izbrisati svoj račun? Neki povezani podaci mogu biti zadržani. Za zahtjev potpunog brisanja podataka, molimo kontaktirajte podršku.', + 'Jeste li sigurni da želite izbrisati svoj račun? Neki povezani podaci mogu biti zadržani. Zahtjev za potpuno brisanje podataka pošaljite podršci.',packages/localizations/src/id-ID.ts (1)
1045-1045: LGTM! Change aligns with PR objectives.The updated Indonesian translation successfully removes the explicit mention of the service name and adopts the more generic messaging about data retention and support contact, consistent with the PR's goal of updating account deletion copy across all locales.
Optional: As this is a community-contributed localization file, having a native Indonesian speaker verify the translation accuracy and naturalness would be beneficial, though the current text appears to follow the expected structure.
packages/localizations/src/ca-ES.ts (1)
1037-1037: Translation is correct, but consider register consistency.The Catalan translation accurately conveys the updated deletion message and successfully removes the Clerk reference per the PR objectives. However, it uses formal register ("Esteu segur que voleu suprimir el vostre compte...") while similar warning messages elsewhere in this file use informal register (e.g., line 411: "Estàs segur que vols eliminar", line 418: "Estàs segur que vols deixar").
If you'd like to maintain consistency with the informal register used throughout the rest of the file, consider this alternative:
- "Esteu segur que voleu suprimir el vostre compte? És possible que es conservin algunes dades associades. Per sol·licitar la supressió completa de les dades, poseu-vos en contacte amb l'assistència.", + "Estàs segur que vols suprimir el teu compte? És possible que es conservin algunes dades associades. Per sol·licitar la supressió completa de les dades, posa't en contacte amb l'assistència.",
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (50)
packages/localizations/src/ar-SA.ts(1 hunks)packages/localizations/src/be-BY.ts(1 hunks)packages/localizations/src/bg-BG.ts(1 hunks)packages/localizations/src/bn-IN.ts(1 hunks)packages/localizations/src/ca-ES.ts(1 hunks)packages/localizations/src/cs-CZ.ts(1 hunks)packages/localizations/src/da-DK.ts(1 hunks)packages/localizations/src/de-DE.ts(1 hunks)packages/localizations/src/el-GR.ts(1 hunks)packages/localizations/src/en-GB.ts(1 hunks)packages/localizations/src/en-US.ts(1 hunks)packages/localizations/src/es-CR.ts(1 hunks)packages/localizations/src/es-ES.ts(1 hunks)packages/localizations/src/es-MX.ts(1 hunks)packages/localizations/src/es-UY.ts(1 hunks)packages/localizations/src/fa-IR.ts(1 hunks)packages/localizations/src/fi-FI.ts(1 hunks)packages/localizations/src/fr-FR.ts(1 hunks)packages/localizations/src/he-IL.ts(1 hunks)packages/localizations/src/hi-IN.ts(1 hunks)packages/localizations/src/hr-HR.ts(1 hunks)packages/localizations/src/hu-HU.ts(1 hunks)packages/localizations/src/id-ID.ts(1 hunks)packages/localizations/src/is-IS.ts(1 hunks)packages/localizations/src/it-IT.ts(1 hunks)packages/localizations/src/ja-JP.ts(1 hunks)packages/localizations/src/kk-KZ.ts(1 hunks)packages/localizations/src/ko-KR.ts(1 hunks)packages/localizations/src/mn-MN.ts(1 hunks)packages/localizations/src/ms-MY.ts(1 hunks)packages/localizations/src/nb-NO.ts(1 hunks)packages/localizations/src/nl-BE.ts(1 hunks)packages/localizations/src/nl-NL.ts(1 hunks)packages/localizations/src/pl-PL.ts(1 hunks)packages/localizations/src/pt-BR.ts(1 hunks)packages/localizations/src/pt-PT.ts(1 hunks)packages/localizations/src/ro-RO.ts(1 hunks)packages/localizations/src/ru-RU.ts(1 hunks)packages/localizations/src/sk-SK.ts(1 hunks)packages/localizations/src/sr-RS.ts(1 hunks)packages/localizations/src/sv-SE.ts(1 hunks)packages/localizations/src/ta-IN.ts(1 hunks)packages/localizations/src/te-IN.ts(1 hunks)packages/localizations/src/th-TH.ts(1 hunks)packages/localizations/src/tr-TR.ts(1 hunks)packages/localizations/src/uk-UA.ts(1 hunks)packages/localizations/src/utils/enUS_v4.ts(1 hunks)packages/localizations/src/vi-VN.ts(1 hunks)packages/localizations/src/zh-CN.ts(1 hunks)packages/localizations/src/zh-TW.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (7)
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
**/*.{js,jsx,ts,tsx}: All code must pass ESLint checks with the project's configuration
Follow established naming conventions (PascalCase for components, camelCase for variables)
Maintain comprehensive JSDoc comments for public APIs
Use dynamic imports for optional features
All public APIs must be documented with JSDoc
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Profile and optimize critical paths
Validate all inputs and sanitize outputs
Implement proper logging with different levels
Files:
packages/localizations/src/he-IL.tspackages/localizations/src/de-DE.tspackages/localizations/src/ro-RO.tspackages/localizations/src/hi-IN.tspackages/localizations/src/be-BY.tspackages/localizations/src/da-DK.tspackages/localizations/src/mn-MN.tspackages/localizations/src/zh-TW.tspackages/localizations/src/ta-IN.tspackages/localizations/src/nb-NO.tspackages/localizations/src/uk-UA.tspackages/localizations/src/hu-HU.tspackages/localizations/src/vi-VN.tspackages/localizations/src/es-CR.tspackages/localizations/src/ru-RU.tspackages/localizations/src/bg-BG.tspackages/localizations/src/cs-CZ.tspackages/localizations/src/sr-RS.tspackages/localizations/src/sv-SE.tspackages/localizations/src/nl-BE.tspackages/localizations/src/fa-IR.tspackages/localizations/src/is-IS.tspackages/localizations/src/te-IN.tspackages/localizations/src/es-UY.tspackages/localizations/src/bn-IN.tspackages/localizations/src/fr-FR.tspackages/localizations/src/ar-SA.tspackages/localizations/src/en-GB.tspackages/localizations/src/it-IT.tspackages/localizations/src/pl-PL.tspackages/localizations/src/pt-BR.tspackages/localizations/src/zh-CN.tspackages/localizations/src/fi-FI.tspackages/localizations/src/es-MX.tspackages/localizations/src/pt-PT.tspackages/localizations/src/ja-JP.tspackages/localizations/src/tr-TR.tspackages/localizations/src/el-GR.tspackages/localizations/src/en-US.tspackages/localizations/src/es-ES.tspackages/localizations/src/id-ID.tspackages/localizations/src/sk-SK.tspackages/localizations/src/hr-HR.tspackages/localizations/src/ms-MY.tspackages/localizations/src/ca-ES.tspackages/localizations/src/utils/enUS_v4.tspackages/localizations/src/th-TH.tspackages/localizations/src/ko-KR.tspackages/localizations/src/kk-KZ.tspackages/localizations/src/nl-NL.ts
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use Prettier for consistent code formatting
Files:
packages/localizations/src/he-IL.tspackages/localizations/src/de-DE.tspackages/localizations/src/ro-RO.tspackages/localizations/src/hi-IN.tspackages/localizations/src/be-BY.tspackages/localizations/src/da-DK.tspackages/localizations/src/mn-MN.tspackages/localizations/src/zh-TW.tspackages/localizations/src/ta-IN.tspackages/localizations/src/nb-NO.tspackages/localizations/src/uk-UA.tspackages/localizations/src/hu-HU.tspackages/localizations/src/vi-VN.tspackages/localizations/src/es-CR.tspackages/localizations/src/ru-RU.tspackages/localizations/src/bg-BG.tspackages/localizations/src/cs-CZ.tspackages/localizations/src/sr-RS.tspackages/localizations/src/sv-SE.tspackages/localizations/src/nl-BE.tspackages/localizations/src/fa-IR.tspackages/localizations/src/is-IS.tspackages/localizations/src/te-IN.tspackages/localizations/src/es-UY.tspackages/localizations/src/bn-IN.tspackages/localizations/src/fr-FR.tspackages/localizations/src/ar-SA.tspackages/localizations/src/en-GB.tspackages/localizations/src/it-IT.tspackages/localizations/src/pl-PL.tspackages/localizations/src/pt-BR.tspackages/localizations/src/zh-CN.tspackages/localizations/src/fi-FI.tspackages/localizations/src/es-MX.tspackages/localizations/src/pt-PT.tspackages/localizations/src/ja-JP.tspackages/localizations/src/tr-TR.tspackages/localizations/src/el-GR.tspackages/localizations/src/en-US.tspackages/localizations/src/es-ES.tspackages/localizations/src/id-ID.tspackages/localizations/src/sk-SK.tspackages/localizations/src/hr-HR.tspackages/localizations/src/ms-MY.tspackages/localizations/src/ca-ES.tspackages/localizations/src/utils/enUS_v4.tspackages/localizations/src/th-TH.tspackages/localizations/src/ko-KR.tspackages/localizations/src/kk-KZ.tspackages/localizations/src/nl-NL.ts
packages/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
TypeScript is required for all packages
Files:
packages/localizations/src/he-IL.tspackages/localizations/src/de-DE.tspackages/localizations/src/ro-RO.tspackages/localizations/src/hi-IN.tspackages/localizations/src/be-BY.tspackages/localizations/src/da-DK.tspackages/localizations/src/mn-MN.tspackages/localizations/src/zh-TW.tspackages/localizations/src/ta-IN.tspackages/localizations/src/nb-NO.tspackages/localizations/src/uk-UA.tspackages/localizations/src/hu-HU.tspackages/localizations/src/vi-VN.tspackages/localizations/src/es-CR.tspackages/localizations/src/ru-RU.tspackages/localizations/src/bg-BG.tspackages/localizations/src/cs-CZ.tspackages/localizations/src/sr-RS.tspackages/localizations/src/sv-SE.tspackages/localizations/src/nl-BE.tspackages/localizations/src/fa-IR.tspackages/localizations/src/is-IS.tspackages/localizations/src/te-IN.tspackages/localizations/src/es-UY.tspackages/localizations/src/bn-IN.tspackages/localizations/src/fr-FR.tspackages/localizations/src/ar-SA.tspackages/localizations/src/en-GB.tspackages/localizations/src/it-IT.tspackages/localizations/src/pl-PL.tspackages/localizations/src/pt-BR.tspackages/localizations/src/zh-CN.tspackages/localizations/src/fi-FI.tspackages/localizations/src/es-MX.tspackages/localizations/src/pt-PT.tspackages/localizations/src/ja-JP.tspackages/localizations/src/tr-TR.tspackages/localizations/src/el-GR.tspackages/localizations/src/en-US.tspackages/localizations/src/es-ES.tspackages/localizations/src/id-ID.tspackages/localizations/src/sk-SK.tspackages/localizations/src/hr-HR.tspackages/localizations/src/ms-MY.tspackages/localizations/src/ca-ES.tspackages/localizations/src/utils/enUS_v4.tspackages/localizations/src/th-TH.tspackages/localizations/src/ko-KR.tspackages/localizations/src/kk-KZ.tspackages/localizations/src/nl-NL.ts
packages/**/*.{ts,tsx,d.ts}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Packages should export TypeScript types alongside runtime code
Files:
packages/localizations/src/he-IL.tspackages/localizations/src/de-DE.tspackages/localizations/src/ro-RO.tspackages/localizations/src/hi-IN.tspackages/localizations/src/be-BY.tspackages/localizations/src/da-DK.tspackages/localizations/src/mn-MN.tspackages/localizations/src/zh-TW.tspackages/localizations/src/ta-IN.tspackages/localizations/src/nb-NO.tspackages/localizations/src/uk-UA.tspackages/localizations/src/hu-HU.tspackages/localizations/src/vi-VN.tspackages/localizations/src/es-CR.tspackages/localizations/src/ru-RU.tspackages/localizations/src/bg-BG.tspackages/localizations/src/cs-CZ.tspackages/localizations/src/sr-RS.tspackages/localizations/src/sv-SE.tspackages/localizations/src/nl-BE.tspackages/localizations/src/fa-IR.tspackages/localizations/src/is-IS.tspackages/localizations/src/te-IN.tspackages/localizations/src/es-UY.tspackages/localizations/src/bn-IN.tspackages/localizations/src/fr-FR.tspackages/localizations/src/ar-SA.tspackages/localizations/src/en-GB.tspackages/localizations/src/it-IT.tspackages/localizations/src/pl-PL.tspackages/localizations/src/pt-BR.tspackages/localizations/src/zh-CN.tspackages/localizations/src/fi-FI.tspackages/localizations/src/es-MX.tspackages/localizations/src/pt-PT.tspackages/localizations/src/ja-JP.tspackages/localizations/src/tr-TR.tspackages/localizations/src/el-GR.tspackages/localizations/src/en-US.tspackages/localizations/src/es-ES.tspackages/localizations/src/id-ID.tspackages/localizations/src/sk-SK.tspackages/localizations/src/hr-HR.tspackages/localizations/src/ms-MY.tspackages/localizations/src/ca-ES.tspackages/localizations/src/utils/enUS_v4.tspackages/localizations/src/th-TH.tspackages/localizations/src/ko-KR.tspackages/localizations/src/kk-KZ.tspackages/localizations/src/nl-NL.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use proper TypeScript error types
**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoidanytype - preferunknownwhen type is uncertain, then narrow with type guards
Useinterfacefor object shapes that might be extended
Usetypefor unions, primitives, and computed types
Preferreadonlyproperties for immutable data structures
Useprivatefor internal implementation details
Useprotectedfor inheritance hierarchies
Usepublicexplicitly for clarity in public APIs
Preferreadonlyfor properties that shouldn't change after construction
Prefer composition and interfaces over deep inheritance chains
Use mixins for shared behavior across unrelated classes
Implement dependency injection for loose coupling
Let TypeScript infer when types are obvious
Useconst assertionsfor literal types:as const
Usesatisfiesoperator for type checking without widening
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Use type-only imports:import type { ... } from ...
Noanytypes without justification
Proper error handling with typed errors
Consistent use ofreadonlyfor immutable data
Proper generic constraints
No unused type parameters
Proper use of utility types instead of manual type construction
Type-only imports where possible
Proper tree-shaking friendly exports
No circular dependencies
Efficient type computations (avoid deep recursion)
Files:
packages/localizations/src/he-IL.tspackages/localizations/src/de-DE.tspackages/localizations/src/ro-RO.tspackages/localizations/src/hi-IN.tspackages/localizations/src/be-BY.tspackages/localizations/src/da-DK.tspackages/localizations/src/mn-MN.tspackages/localizations/src/zh-TW.tspackages/localizations/src/ta-IN.tspackages/localizations/src/nb-NO.tspackages/localizations/src/uk-UA.tspackages/localizations/src/hu-HU.tspackages/localizations/src/vi-VN.tspackages/localizations/src/es-CR.tspackages/localizations/src/ru-RU.tspackages/localizations/src/bg-BG.tspackages/localizations/src/cs-CZ.tspackages/localizations/src/sr-RS.tspackages/localizations/src/sv-SE.tspackages/localizations/src/nl-BE.tspackages/localizations/src/fa-IR.tspackages/localizations/src/is-IS.tspackages/localizations/src/te-IN.tspackages/localizations/src/es-UY.tspackages/localizations/src/bn-IN.tspackages/localizations/src/fr-FR.tspackages/localizations/src/ar-SA.tspackages/localizations/src/en-GB.tspackages/localizations/src/it-IT.tspackages/localizations/src/pl-PL.tspackages/localizations/src/pt-BR.tspackages/localizations/src/zh-CN.tspackages/localizations/src/fi-FI.tspackages/localizations/src/es-MX.tspackages/localizations/src/pt-PT.tspackages/localizations/src/ja-JP.tspackages/localizations/src/tr-TR.tspackages/localizations/src/el-GR.tspackages/localizations/src/en-US.tspackages/localizations/src/es-ES.tspackages/localizations/src/id-ID.tspackages/localizations/src/sk-SK.tspackages/localizations/src/hr-HR.tspackages/localizations/src/ms-MY.tspackages/localizations/src/ca-ES.tspackages/localizations/src/utils/enUS_v4.tspackages/localizations/src/th-TH.tspackages/localizations/src/ko-KR.tspackages/localizations/src/kk-KZ.tspackages/localizations/src/nl-NL.ts
packages/localizations/**/*
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Localization files must be placed in 'packages/localizations/'.
Files:
packages/localizations/src/he-IL.tspackages/localizations/src/de-DE.tspackages/localizations/src/ro-RO.tspackages/localizations/src/hi-IN.tspackages/localizations/src/be-BY.tspackages/localizations/src/da-DK.tspackages/localizations/src/mn-MN.tspackages/localizations/src/zh-TW.tspackages/localizations/src/ta-IN.tspackages/localizations/src/nb-NO.tspackages/localizations/src/uk-UA.tspackages/localizations/src/hu-HU.tspackages/localizations/src/vi-VN.tspackages/localizations/src/es-CR.tspackages/localizations/src/ru-RU.tspackages/localizations/src/bg-BG.tspackages/localizations/src/cs-CZ.tspackages/localizations/src/sr-RS.tspackages/localizations/src/sv-SE.tspackages/localizations/src/nl-BE.tspackages/localizations/src/fa-IR.tspackages/localizations/src/is-IS.tspackages/localizations/src/te-IN.tspackages/localizations/src/es-UY.tspackages/localizations/src/bn-IN.tspackages/localizations/src/fr-FR.tspackages/localizations/src/ar-SA.tspackages/localizations/src/en-GB.tspackages/localizations/src/it-IT.tspackages/localizations/src/pl-PL.tspackages/localizations/src/pt-BR.tspackages/localizations/src/zh-CN.tspackages/localizations/src/fi-FI.tspackages/localizations/src/es-MX.tspackages/localizations/src/pt-PT.tspackages/localizations/src/ja-JP.tspackages/localizations/src/tr-TR.tspackages/localizations/src/el-GR.tspackages/localizations/src/en-US.tspackages/localizations/src/es-ES.tspackages/localizations/src/id-ID.tspackages/localizations/src/sk-SK.tspackages/localizations/src/hr-HR.tspackages/localizations/src/ms-MY.tspackages/localizations/src/ca-ES.tspackages/localizations/src/utils/enUS_v4.tspackages/localizations/src/th-TH.tspackages/localizations/src/ko-KR.tspackages/localizations/src/kk-KZ.tspackages/localizations/src/nl-NL.ts
**/*.{js,ts,tsx,jsx}
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Support multiple Clerk environment variables (CLERK_, NEXT_PUBLIC_CLERK_, etc.) for configuration.
Files:
packages/localizations/src/he-IL.tspackages/localizations/src/de-DE.tspackages/localizations/src/ro-RO.tspackages/localizations/src/hi-IN.tspackages/localizations/src/be-BY.tspackages/localizations/src/da-DK.tspackages/localizations/src/mn-MN.tspackages/localizations/src/zh-TW.tspackages/localizations/src/ta-IN.tspackages/localizations/src/nb-NO.tspackages/localizations/src/uk-UA.tspackages/localizations/src/hu-HU.tspackages/localizations/src/vi-VN.tspackages/localizations/src/es-CR.tspackages/localizations/src/ru-RU.tspackages/localizations/src/bg-BG.tspackages/localizations/src/cs-CZ.tspackages/localizations/src/sr-RS.tspackages/localizations/src/sv-SE.tspackages/localizations/src/nl-BE.tspackages/localizations/src/fa-IR.tspackages/localizations/src/is-IS.tspackages/localizations/src/te-IN.tspackages/localizations/src/es-UY.tspackages/localizations/src/bn-IN.tspackages/localizations/src/fr-FR.tspackages/localizations/src/ar-SA.tspackages/localizations/src/en-GB.tspackages/localizations/src/it-IT.tspackages/localizations/src/pl-PL.tspackages/localizations/src/pt-BR.tspackages/localizations/src/zh-CN.tspackages/localizations/src/fi-FI.tspackages/localizations/src/es-MX.tspackages/localizations/src/pt-PT.tspackages/localizations/src/ja-JP.tspackages/localizations/src/tr-TR.tspackages/localizations/src/el-GR.tspackages/localizations/src/en-US.tspackages/localizations/src/es-ES.tspackages/localizations/src/id-ID.tspackages/localizations/src/sk-SK.tspackages/localizations/src/hr-HR.tspackages/localizations/src/ms-MY.tspackages/localizations/src/ca-ES.tspackages/localizations/src/utils/enUS_v4.tspackages/localizations/src/th-TH.tspackages/localizations/src/ko-KR.tspackages/localizations/src/kk-KZ.tspackages/localizations/src/nl-NL.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Build Packages
- GitHub Check: semgrep/ci
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (22)
packages/localizations/src/tr-TR.ts (1)
1038-1040: Translation update matches new copyThe revised Turkish string mirrors the updated English messaging while keeping tone and intent consistent. Looks good to me.
packages/localizations/src/he-IL.ts (1)
1021-1024: Translation alignment looks good.Updated Hebrew copy accurately reflects the new English guidance while retaining the existing tone and structure. Thanks for keeping it consistent.
packages/localizations/src/el-GR.ts (1)
1041-1041: Translation looks spot on.The updated Greek copy faithfully mirrors the new English messaging and keeps the tone consistent with the rest of the locale file. Nice work.
packages/localizations/src/nl-NL.ts (1)
1035-1035: Copy update looks good.Dutch translation matches the new English messaging and reads naturally.
packages/localizations/src/ta-IN.ts (1)
1052-1052: Localization update matches new copyTamil string cleanly mirrors the new generic deletion warning and keeps the support guidance intact. No issues spotted.
packages/localizations/src/cs-CZ.ts (1)
1046-1046: LGTM! Czech translation accurately reflects the PR objectives.The updated account deletion confirmation message successfully:
- Removes explicit Clerk references
- Provides clear, generic user-facing guidance about data retention
- Maintains proper Czech grammar and professional tone
- Aligns with the English version changes described in the PR objectives
The translation is accurate and consistent with the localization patterns used throughout the file.
packages/localizations/src/es-CR.ts (1)
1044-1045: LGTM! Spanish translation accurately reflects the updated messaging.The updated deletion confirmation message successfully removes the Clerk-specific reference and adopts a generic, professional tone. The Spanish translation is grammatically correct, uses appropriate formal register (usted form) for this context, and clearly communicates the data retention notice and support contact instruction as intended by the PR objectives.
packages/localizations/src/hu-HU.ts (1)
1036-1036: LGTM! The Hungarian translation accurately reflects the updated messaging.The updated account deletion confirmation message successfully removes Clerk-specific references and provides clear, generic guidance about data retention and support contact. The Hungarian translation is grammatically correct, uses appropriate formal language ("szeretné"), and maintains a professional tone suitable for this critical user action.
packages/localizations/src/vi-VN.ts (1)
1043-1043: LGTM! Accurate Vietnamese translation of the updated deletion message.The Vietnamese translation correctly conveys the new generic account deletion confirmation message. The text is natural, grammatically correct, and aligns with the PR objectives to remove explicit references to Clerk while informing users about data retention and support contact.
packages/localizations/src/uk-UA.ts (1)
1032-1032: LGTM! Localization update aligns with PR objectives.The Ukrainian translation accurately reflects the new generic account deletion confirmation message. It removes Clerk-specific references, notes potential data retention, and directs users to contact support—consistent with the PR's intent.
packages/localizations/src/pl-PL.ts (1)
1043-1044: LGTM! Polish localization correctly implements the updated deletion message.The Polish translation accurately reflects the new generic account deletion message without Clerk-specific references. The text is grammatically correct and uses natural, idiomatic Polish phrasing appropriate for technical support contexts.
packages/localizations/src/is-IS.ts (1)
1038-1039: LGTM! The message aligns with the PR objectives.The deletion confirmation message has been successfully updated to remove the explicit Clerk reference and adopt generic language about data retention and contacting support. The structural change matches the pattern described in the PR objectives.
While the change looks correct, consider having a native Icelandic speaker verify the translation quality to ensure:
- Natural phrasing and grammar
- Proper formality level ("þjónustuver" for support)
- Semantic equivalence with the English version across all locale files
packages/localizations/src/be-BY.ts (1)
1042-1042: LGTM! Deletion message updated per PR objectives.The account deletion confirmation message has been successfully updated to remove Clerk-specific references and provide a generic notice about data retention with support contact guidance. The change aligns with the PR objectives across all locale files.
If native Belarusian speakers are available for review, consider having them verify the translation accuracy to ensure the legal and privacy implications are appropriately conveyed in the local language.
packages/localizations/src/hi-IN.ts (1)
1045-1045: LGTM! Account deletion message updated per PR objectives.The Hindi translation successfully removes Clerk-specific references and provides a generic deletion confirmation message with data retention notice and support contact directive. The translation structure appears grammatically sound and follows the intended English phrasing.
Since this is a community-contributed localization file (per the disclaimer at lines 3-11), consider having a native Hindi speaker verify the translation accuracy for production use.
packages/localizations/src/bn-IN.ts (1)
1045-1045: LGTM! Translation aligns with PR objectives.The updated account deletion confirmation message successfully removes Clerk-specific references and adopts the new generic phrasing about data retention with guidance to contact support. The Bengali translation appears consistent with the new English copy.
As this is a community-contributed localization file (per the disclaimer), consider having a native Bengali speaker verify the translation accuracy to ensure it properly conveys the intended message and maintains natural phrasing.
packages/localizations/src/ru-RU.ts (1)
1050-1051: LGTM! Translation accurately reflects the privacy-focused messaging.The Russian translation properly conveys the updated account deletion message that removes Clerk-specific references and adopts a more generic, privacy-focused approach. The translation is clear, grammatically correct, and maintains consistency with the PR's objectives.
packages/localizations/src/te-IN.ts (1)
1047-1047: Approve localization update: The deletion confirmation message aligns with PR objectives and the Telugu translation is accurate.packages/localizations/src/ja-JP.ts (1)
1035-1037: Japanese copy aligns with the revised guidance.Updated phrasing captures the retention caveat and support escalation cleanly. ✅
packages/localizations/src/en-US.ts (1)
1034-1037: US-English message matches the new product wording.Copy now reflects the neutral deletion notice with the support escalation path.
packages/localizations/src/en-GB.ts (1)
1039-1042: UK-English locale updated consistently.Message mirrors the new neutral copy and keeps locale expectations intact.
packages/localizations/src/sr-RS.ts (1)
1033-1035: Serbian translation reads correctly.New text reflects the retention warning and support escalation without regressions.
packages/localizations/src/it-IT.ts (1)
1043-1046: Italian locale updated as intended.Copy clearly communicates possible retention and the support escalation path.
jescalan
changed the title
jescalan
changed the title
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
jescalan
force-pushed
the
je.update-deletion-message
branch
from
8648c70 to
917f713
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
packages/localizations/src/pl-PL.ts (1)
1043-1044: Minor terminology consideration: "technical support" vs "support".The Polish translation uses "pomocą techniczną" (technical support) while the English version in the PR description uses the simpler "contact support." Consider whether "skontaktuj się z pomocą" (contact support) would better match the intended terminology across all localizations, or if the additional specificity of "technical support" is preferred for the Polish locale.
Otherwise, the translation is grammatically correct and accurately conveys the updated account deletion message.
If alignment with the English terminology is preferred, apply this diff:
- 'Czy na pewno chcesz usunąć swoje konto? Niektóre powiązane dane mogą zostać zachowane. Aby poprosić o całkowite usunięcie danych, skontaktuj się z pomocą techniczną.', + 'Czy na pewno chcesz usunąć swoje konto? Niektóre powiązane dane mogą zostać zachowane. Aby poprosić o całkowite usunięcie danych, skontaktuj się z pomocą.',packages/localizations/src/pt-PT.ts (1)
1033-1034: LGTM! Translation accurately reflects the updated deletion message.The Portuguese translation correctly implements the PR objective by removing Clerk references and providing a generic deletion notice with data retention information. The message is grammatically correct and idiomatic for PT-PT, using appropriate formal imperatives ("contacte o suporte").
Minor observation: There's a terminology variance within the
deletePageobject—this line uses "eliminar a sua conta" while the title (line 1036) and confirm button (line 1032) use "Excluir conta". Both terms are acceptable in Portuguese and convey the same meaning, though maintaining consistent terminology within the same context could improve cohesion. This is a very minor point and doesn't require immediate action.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (51)
.changeset/weak-baboons-buy.md(1 hunks)packages/localizations/src/ar-SA.ts(1 hunks)packages/localizations/src/be-BY.ts(1 hunks)packages/localizations/src/bg-BG.ts(1 hunks)packages/localizations/src/bn-IN.ts(1 hunks)packages/localizations/src/ca-ES.ts(1 hunks)packages/localizations/src/cs-CZ.ts(1 hunks)packages/localizations/src/da-DK.ts(1 hunks)packages/localizations/src/de-DE.ts(1 hunks)packages/localizations/src/el-GR.ts(1 hunks)packages/localizations/src/en-GB.ts(1 hunks)packages/localizations/src/en-US.ts(1 hunks)packages/localizations/src/es-CR.ts(1 hunks)packages/localizations/src/es-ES.ts(1 hunks)packages/localizations/src/es-MX.ts(1 hunks)packages/localizations/src/es-UY.ts(1 hunks)packages/localizations/src/fa-IR.ts(1 hunks)packages/localizations/src/fi-FI.ts(1 hunks)packages/localizations/src/fr-FR.ts(1 hunks)packages/localizations/src/he-IL.ts(1 hunks)packages/localizations/src/hi-IN.ts(1 hunks)packages/localizations/src/hr-HR.ts(1 hunks)packages/localizations/src/hu-HU.ts(1 hunks)packages/localizations/src/id-ID.ts(1 hunks)packages/localizations/src/is-IS.ts(1 hunks)packages/localizations/src/it-IT.ts(1 hunks)packages/localizations/src/ja-JP.ts(1 hunks)packages/localizations/src/kk-KZ.ts(1 hunks)packages/localizations/src/ko-KR.ts(1 hunks)packages/localizations/src/mn-MN.ts(1 hunks)packages/localizations/src/ms-MY.ts(1 hunks)packages/localizations/src/nb-NO.ts(1 hunks)packages/localizations/src/nl-BE.ts(1 hunks)packages/localizations/src/nl-NL.ts(1 hunks)packages/localizations/src/pl-PL.ts(1 hunks)packages/localizations/src/pt-BR.ts(1 hunks)packages/localizations/src/pt-PT.ts(1 hunks)packages/localizations/src/ro-RO.ts(1 hunks)packages/localizations/src/ru-RU.ts(1 hunks)packages/localizations/src/sk-SK.ts(1 hunks)packages/localizations/src/sr-RS.ts(1 hunks)packages/localizations/src/sv-SE.ts(1 hunks)packages/localizations/src/ta-IN.ts(1 hunks)packages/localizations/src/te-IN.ts(1 hunks)packages/localizations/src/th-TH.ts(1 hunks)packages/localizations/src/tr-TR.ts(1 hunks)packages/localizations/src/uk-UA.ts(1 hunks)packages/localizations/src/utils/enUS_v4.ts(1 hunks)packages/localizations/src/vi-VN.ts(1 hunks)packages/localizations/src/zh-CN.ts(1 hunks)packages/localizations/src/zh-TW.ts(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- .changeset/weak-baboons-buy.md
- packages/localizations/src/vi-VN.ts
🚧 Files skipped from review as they are similar to previous changes (31)
- packages/localizations/src/bg-BG.ts
- packages/localizations/src/he-IL.ts
- packages/localizations/src/de-DE.ts
- packages/localizations/src/hr-HR.ts
- packages/localizations/src/pt-BR.ts
- packages/localizations/src/el-GR.ts
- packages/localizations/src/uk-UA.ts
- packages/localizations/src/ca-ES.ts
- packages/localizations/src/da-DK.ts
- packages/localizations/src/fi-FI.ts
- packages/localizations/src/nb-NO.ts
- packages/localizations/src/it-IT.ts
- packages/localizations/src/th-TH.ts
- packages/localizations/src/tr-TR.ts
- packages/localizations/src/id-ID.ts
- packages/localizations/src/ta-IN.ts
- packages/localizations/src/fr-FR.ts
- packages/localizations/src/zh-CN.ts
- packages/localizations/src/zh-TW.ts
- packages/localizations/src/is-IS.ts
- packages/localizations/src/nl-BE.ts
- packages/localizations/src/es-ES.ts
- packages/localizations/src/en-GB.ts
- packages/localizations/src/cs-CZ.ts
- packages/localizations/src/te-IN.ts
- packages/localizations/src/en-US.ts
- packages/localizations/src/kk-KZ.ts
- packages/localizations/src/ja-JP.ts
- packages/localizations/src/nl-NL.ts
- packages/localizations/src/sk-SK.ts
- packages/localizations/src/ar-SA.ts
🧰 Additional context used
📓 Path-based instructions (7)
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
**/*.{js,jsx,ts,tsx}: All code must pass ESLint checks with the project's configuration
Follow established naming conventions (PascalCase for components, camelCase for variables)
Maintain comprehensive JSDoc comments for public APIs
Use dynamic imports for optional features
All public APIs must be documented with JSDoc
Provide meaningful error messages to developers
Include error recovery suggestions where applicable
Log errors appropriately for debugging
Lazy load components and features when possible
Implement proper caching strategies
Use efficient data structures and algorithms
Profile and optimize critical paths
Validate all inputs and sanitize outputs
Implement proper logging with different levels
Files:
packages/localizations/src/bn-IN.tspackages/localizations/src/pt-PT.tspackages/localizations/src/hu-HU.tspackages/localizations/src/es-CR.tspackages/localizations/src/ru-RU.tspackages/localizations/src/mn-MN.tspackages/localizations/src/es-MX.tspackages/localizations/src/pl-PL.tspackages/localizations/src/fa-IR.tspackages/localizations/src/utils/enUS_v4.tspackages/localizations/src/ro-RO.tspackages/localizations/src/es-UY.tspackages/localizations/src/sr-RS.tspackages/localizations/src/be-BY.tspackages/localizations/src/sv-SE.tspackages/localizations/src/ko-KR.tspackages/localizations/src/ms-MY.tspackages/localizations/src/hi-IN.ts
**/*.{js,jsx,ts,tsx,json,css,scss,md,yaml,yml}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use Prettier for consistent code formatting
Files:
packages/localizations/src/bn-IN.tspackages/localizations/src/pt-PT.tspackages/localizations/src/hu-HU.tspackages/localizations/src/es-CR.tspackages/localizations/src/ru-RU.tspackages/localizations/src/mn-MN.tspackages/localizations/src/es-MX.tspackages/localizations/src/pl-PL.tspackages/localizations/src/fa-IR.tspackages/localizations/src/utils/enUS_v4.tspackages/localizations/src/ro-RO.tspackages/localizations/src/es-UY.tspackages/localizations/src/sr-RS.tspackages/localizations/src/be-BY.tspackages/localizations/src/sv-SE.tspackages/localizations/src/ko-KR.tspackages/localizations/src/ms-MY.tspackages/localizations/src/hi-IN.ts
packages/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
TypeScript is required for all packages
Files:
packages/localizations/src/bn-IN.tspackages/localizations/src/pt-PT.tspackages/localizations/src/hu-HU.tspackages/localizations/src/es-CR.tspackages/localizations/src/ru-RU.tspackages/localizations/src/mn-MN.tspackages/localizations/src/es-MX.tspackages/localizations/src/pl-PL.tspackages/localizations/src/fa-IR.tspackages/localizations/src/utils/enUS_v4.tspackages/localizations/src/ro-RO.tspackages/localizations/src/es-UY.tspackages/localizations/src/sr-RS.tspackages/localizations/src/be-BY.tspackages/localizations/src/sv-SE.tspackages/localizations/src/ko-KR.tspackages/localizations/src/ms-MY.tspackages/localizations/src/hi-IN.ts
packages/**/*.{ts,tsx,d.ts}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Packages should export TypeScript types alongside runtime code
Files:
packages/localizations/src/bn-IN.tspackages/localizations/src/pt-PT.tspackages/localizations/src/hu-HU.tspackages/localizations/src/es-CR.tspackages/localizations/src/ru-RU.tspackages/localizations/src/mn-MN.tspackages/localizations/src/es-MX.tspackages/localizations/src/pl-PL.tspackages/localizations/src/fa-IR.tspackages/localizations/src/utils/enUS_v4.tspackages/localizations/src/ro-RO.tspackages/localizations/src/es-UY.tspackages/localizations/src/sr-RS.tspackages/localizations/src/be-BY.tspackages/localizations/src/sv-SE.tspackages/localizations/src/ko-KR.tspackages/localizations/src/ms-MY.tspackages/localizations/src/hi-IN.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/development.mdc)
Use proper TypeScript error types
**/*.{ts,tsx}: Always define explicit return types for functions, especially public APIs
Use proper type annotations for variables and parameters where inference isn't clear
Avoidanytype - preferunknownwhen type is uncertain, then narrow with type guards
Useinterfacefor object shapes that might be extended
Usetypefor unions, primitives, and computed types
Preferreadonlyproperties for immutable data structures
Useprivatefor internal implementation details
Useprotectedfor inheritance hierarchies
Usepublicexplicitly for clarity in public APIs
Preferreadonlyfor properties that shouldn't change after construction
Prefer composition and interfaces over deep inheritance chains
Use mixins for shared behavior across unrelated classes
Implement dependency injection for loose coupling
Let TypeScript infer when types are obvious
Useconst assertionsfor literal types:as const
Usesatisfiesoperator for type checking without widening
Use mapped types for transforming object types
Use conditional types for type-level logic
Leverage template literal types for string manipulation
Use ES6 imports/exports consistently
Use default exports sparingly, prefer named exports
Use type-only imports:import type { ... } from ...
Noanytypes without justification
Proper error handling with typed errors
Consistent use ofreadonlyfor immutable data
Proper generic constraints
No unused type parameters
Proper use of utility types instead of manual type construction
Type-only imports where possible
Proper tree-shaking friendly exports
No circular dependencies
Efficient type computations (avoid deep recursion)
Files:
packages/localizations/src/bn-IN.tspackages/localizations/src/pt-PT.tspackages/localizations/src/hu-HU.tspackages/localizations/src/es-CR.tspackages/localizations/src/ru-RU.tspackages/localizations/src/mn-MN.tspackages/localizations/src/es-MX.tspackages/localizations/src/pl-PL.tspackages/localizations/src/fa-IR.tspackages/localizations/src/utils/enUS_v4.tspackages/localizations/src/ro-RO.tspackages/localizations/src/es-UY.tspackages/localizations/src/sr-RS.tspackages/localizations/src/be-BY.tspackages/localizations/src/sv-SE.tspackages/localizations/src/ko-KR.tspackages/localizations/src/ms-MY.tspackages/localizations/src/hi-IN.ts
packages/localizations/**/*
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Localization files must be placed in 'packages/localizations/'.
Files:
packages/localizations/src/bn-IN.tspackages/localizations/src/pt-PT.tspackages/localizations/src/hu-HU.tspackages/localizations/src/es-CR.tspackages/localizations/src/ru-RU.tspackages/localizations/src/mn-MN.tspackages/localizations/src/es-MX.tspackages/localizations/src/pl-PL.tspackages/localizations/src/fa-IR.tspackages/localizations/src/utils/enUS_v4.tspackages/localizations/src/ro-RO.tspackages/localizations/src/es-UY.tspackages/localizations/src/sr-RS.tspackages/localizations/src/be-BY.tspackages/localizations/src/sv-SE.tspackages/localizations/src/ko-KR.tspackages/localizations/src/ms-MY.tspackages/localizations/src/hi-IN.ts
**/*.{js,ts,tsx,jsx}
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Support multiple Clerk environment variables (CLERK_, NEXT_PUBLIC_CLERK_, etc.) for configuration.
Files:
packages/localizations/src/bn-IN.tspackages/localizations/src/pt-PT.tspackages/localizations/src/hu-HU.tspackages/localizations/src/es-CR.tspackages/localizations/src/ru-RU.tspackages/localizations/src/mn-MN.tspackages/localizations/src/es-MX.tspackages/localizations/src/pl-PL.tspackages/localizations/src/fa-IR.tspackages/localizations/src/utils/enUS_v4.tspackages/localizations/src/ro-RO.tspackages/localizations/src/es-UY.tspackages/localizations/src/sr-RS.tspackages/localizations/src/be-BY.tspackages/localizations/src/sv-SE.tspackages/localizations/src/ko-KR.tspackages/localizations/src/ms-MY.tspackages/localizations/src/hi-IN.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (30)
- GitHub Check: Integration Tests (custom, chrome)
- GitHub Check: Integration Tests (nextjs, chrome, 14)
- GitHub Check: Integration Tests (nextjs, chrome, 15)
- GitHub Check: Integration Tests (machine, chrome)
- GitHub Check: Integration Tests (sessions:staging, chrome)
- GitHub Check: Integration Tests (nuxt, chrome)
- GitHub Check: Integration Tests (vue, chrome)
- GitHub Check: Integration Tests (tanstack-react-start, chrome)
- GitHub Check: Integration Tests (billing, chrome)
- GitHub Check: Integration Tests (handshake, chrome)
- GitHub Check: Integration Tests (sessions, chrome)
- GitHub Check: Integration Tests (react-router, chrome)
- GitHub Check: Integration Tests (ap-flows, chrome)
- GitHub Check: Integration Tests (elements, chrome)
- GitHub Check: Integration Tests (expo-web, chrome)
- GitHub Check: Integration Tests (astro, chrome)
- GitHub Check: Integration Tests (tanstack-react-router, chrome)
- GitHub Check: Integration Tests (handshake:staging, chrome)
- GitHub Check: Integration Tests (generic, chrome)
- GitHub Check: Integration Tests (localhost, chrome)
- GitHub Check: Integration Tests (quickstart, chrome)
- GitHub Check: Integration Tests (express, chrome)
- GitHub Check: Static analysis
- GitHub Check: Unit Tests (18, --filter=@clerk/astro --filter=@clerk/backend --filter=@clerk/express --filter=@c...
- GitHub Check: Publish with pkg-pr-new
- GitHub Check: Unit Tests (22, **)
- GitHub Check: semgrep/ci
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (15)
packages/localizations/src/es-MX.ts (1)
1046-1046: LGTM! Translation accurately implements the updated account deletion message.The Spanish (Mexico) translation correctly conveys the generic account deletion confirmation that removes Clerk-specific references and adds the data retention notice with support contact guidance, aligning with the PR objectives.
packages/localizations/src/hu-HU.ts (1)
1036-1036: LGTM! Clean localization update.The Hungarian translation accurately conveys the genericized account deletion message, maintaining a professional and formal tone appropriate for this context. The message structure clearly communicates the confirmation question, data retention notice, and support contact instruction.
packages/localizations/src/es-UY.ts (1)
1045-1046: LGTM! The message is now consistent with the file's informal tone.The updated account deletion message correctly uses informal Spanish with voseo (Uruguayan dialect), matching the style used throughout the file. The translation is accurate and maintains consistency with similar confirmation messages at lines 412 and 419.
The previous formality inconsistency concern has been addressed.
packages/localizations/src/ko-KR.ts (1)
1026-1027: LGTM! Localization update aligns with PR objectives.The Korean translation successfully removes Clerk-specific references and provides generic data deletion guidance, consistent with the broader localization update across all locale files. The translation structure appropriately conveys:
- Confirmation prompt for account deletion
- Notice that some data may be retained
- Direction to contact support for full data deletion
packages/localizations/src/ru-RU.ts (1)
1051-1051: LGTM! Clear and accurate account deletion message.The updated Russian translation successfully achieves the PR objective by removing explicit Clerk branding and providing clear guidance about data retention and full deletion requests. The translation is accurate, natural, and maintains consistency with the rest of the localization file.
packages/localizations/src/ms-MY.ts (1)
1051-1051: LGTM! Localization update aligns with PR objectives.The updated Malay deletion confirmation message correctly implements the requirements: removes Clerk-specific references, notifies users about potential data retention, and directs them to support for full deletion requests.
packages/localizations/src/be-BY.ts (1)
1042-1042: LGTM! Localization update aligns with PR objectives.The updated Belarusian deletion confirmation message correctly implements the requirements: removes Clerk-specific references, notifies users about potential data retention, and directs them to support for full deletion requests.
packages/localizations/src/ro-RO.ts (1)
1049-1050: LGTM! Tone consistency addressed.The updated deletion confirmation message correctly uses informal language ("vrei", "să-ți", "te rugăm", "contactezi") throughout, matching the tone of the rest of the ro-RO locale. The previous concern about formal vs. informal tone mismatch has been resolved. The translation is accurate and aligns with the PR objectives to provide a generic deletion notice.
packages/localizations/src/es-CR.ts (1)
1045-1045: LGTM! Copy change aligns with PR objectives.The updated account deletion confirmation message successfully removes Clerk-specific references and provides a generic, formal notice about potential data retention. The Spanish translation is grammatically correct and maintains an appropriate formal tone for this sensitive action.
packages/localizations/src/sv-SE.ts (1)
1038-1038: LGTM! Copy change aligns with PR objectives.The updated account deletion confirmation message successfully removes Clerk-specific references and provides a generic notice about potential data retention. The Swedish translation is grammatically correct and maintains the appropriate informal tone (using "du") which is standard for Swedish user interfaces.
packages/localizations/src/sr-RS.ts (1)
1034-1034: LGTM!The updated account deletion confirmation message correctly translates the new generic phrasing to Serbian (Cyrillic). The translation accurately conveys the data retention notice and support contact instruction while maintaining an appropriate formal tone for a critical user action.
packages/localizations/src/mn-MN.ts (1)
1036-1036: LGTM! Deletion message updated per PR objectives.The account deletion confirmation message has been updated to remove Clerk-specific references and provide generic guidance about data retention and support contact, consistent with the PR objectives. The string is properly formatted and the change is purely textual with no functional impact.
Note: As this is a community-contributed localization file (per the disclaimer at the top), ideally a native Mongolian speaker should verify the translation accuracy to ensure it conveys the intended meaning: confirming deletion intent, noting possible data retention, and directing users to contact support for full data deletion.
packages/localizations/src/bn-IN.ts (1)
1045-1045: LGTM! Change aligns with PR objectives.The updated Bengali translation successfully removes Clerk-specific references and introduces the generic data retention notice with a prompt to contact support for full data deletion, as intended by this PR.
If native Bengali speakers are available, consider verifying the translation accuracy to ensure the nuance of "some associated data may be retained" and the support contact instruction are clearly conveyed.
packages/localizations/src/fa-IR.ts (1)
1046-1046: LGTM! Account deletion message successfully updated.The localization change correctly implements the PR objective by:
- Removing explicit mention of Clerk
- Updating to a more generic phrasing about data retention
- Directing users to contact support for full data deletion
The Persian text appears properly formatted with correct RTL directionality and Unicode characters.
Note: While the structure and formatting are correct, definitive verification of translation accuracy would require a native Persian speaker. Consider having this reviewed by a Persian language expert if not already done.
packages/localizations/src/hi-IN.ts (1)
1045-1045: LGTM!The Hindi translation accurately reflects the updated account deletion confirmation message per the PR objectives. The message now generically addresses data retention and directs users to contact support for full data deletion, removing the Clerk-specific branding. The term "सहायता" (support) is used consistently throughout the file.
Note: Given the disclaimer at the top of this file (lines 1-11) indicating this is a community-maintained localization, and considering the legal/compliance implications of account deletion messaging, you may want to verify this translation with a native Hindi speaker if additional assurance is needed.
| messageLine1: | ||
| 'Are you sure you want to delete your account from Clerk? Please contact the application owner to delete your information from their application and other services.', | ||
| 'Are you sure you want to delete your account? Some associated data may be retained. To request full data deletion, please contact support.', |
There was a problem hiding this comment.
🛠️ Refactor suggestion | 🟠 Major
🧩 Analysis chain
LGTM! Improved user transparency and privacy compliance.
The updated deletion confirmation message is clearer and more transparent than the previous version. Key improvements:
- Removes brand-specific references, making it suitable for white-label scenarios
- Explicitly mentions potential data retention, setting proper user expectations
- Provides a clear action path (contact support) for full data deletion requests
- Better aligned with GDPR/CCPA requirements for transparent data deletion rights
Please verify that this change has been consistently applied across all locale files mentioned in the PR (es-ES.ts, es-MX.ts, ja-JP.ts, zh-CN.ts, etc.) to ensure a uniform user experience across all supported languages.
🏁 Script executed:
#!/bin/bash
# Description: Verify that the deletion message has been updated consistently across all locale files.
# Search for the old Clerk-specific deletion message pattern
echo "=== Checking for old Clerk-specific deletion messages ==="
rg -n "delete your account from Clerk" packages/localizations/
# Search for the new generic deletion message pattern
echo -e "\n=== Checking for new generic deletion messages ==="
rg -n "Some associated data may be retained" packages/localizations/
# Count locale files with deletePage.messageLine1
echo -e "\n=== Count of locale files with deletePage.messageLine1 ==="
rg -l "deletePage.*messageLine1" packages/localizations/ | wc -lLength of output: 751
🏁 Script executed:
#!/bin/bash
# List all top-level locale .ts files
echo "Locale files in packages/localizations/src:"
find packages/localizations/src -maxdepth 1 -type f -name '*.ts' -printf "%f\n" | sort
# Which of these contain deletePage
echo -e "\nFiles containing 'deletePage':"
rg -l "deletePage" -g "*.ts" packages/localizations/src | sed 's|.*/||' | sort
# Which contain messageLine1
echo -e "\nFiles containing 'messageLine1':"
rg -l "messageLine1" -g "*.ts" packages/localizations/src | sed 's|.*/||' | sort
# Which contain the new generic deletion message
echo -e "\nFiles with the new generic deletion message:"
rg -l "Some associated data may be retained" packages/localizations/src | sed 's|.*/||' | sortLength of output: 1538
Update deletion confirmation message across all locale files
The new generic deletePage.messageLine1 appears only in en-US.ts, en-GB.ts, and utils/enUS_v4.ts. Apply the updated wording to all other locale files under packages/localizations/src to ensure a consistent user experience.
🤖 Prompt for AI Agents
In packages/localizations/src/utils/enUS_v4.ts around lines 519-520, the
deletion confirmation text is the updated generic wording; ensure that same
exact messageLine1 string ("Are you sure you want to delete your account? Some
associated data may be retained. To request full data deletion, please contact
support.") is propagated to all other locale files under
packages/localizations/src that define deletePage.messageLine1 — open each
locale file, replace the existing deletePage.messageLine1 value with this exact
wording, preserve surrounding file formatting/quotes/commas, and run a quick
lint/format pass to keep consistency.
There was a problem hiding this comment.
I think you're mistaken, I can see that it was applied to all other locale files here as well. Could you check again?
There was a problem hiding this comment.
Note that in the script you used to check other locale files, you searched for the english string, but the locale files use other languages. It may be better to just check and see if the files were all updated.
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify that the deletion message has been updated across all locale files
echo "=== Searching for OLD Clerk-specific message pattern ==="
rg -l "delete your account from Clerk" packages/localizations/src/
echo -e "\n=== Searching for NEW generic message patterns (English) ==="
rg -l "Some associated data may be retained" packages/localizations/src/
echo -e "\n=== Count all locale .ts files ==="
find packages/localizations/src -maxdepth 1 -type f -name '*.ts' | wc -l
echo -e "\n=== Count files with deletePage structure ==="
rg -l "deletePage.*messageLine1" packages/localizations/src/ | wc -l
echo -e "\n=== Check if any files still contain the old Clerk-specific wording ==="
rg -n "contact the application owner" packages/localizations/src/ || echo "No old wording found"
echo -e "\n=== Sample check: Compare a few locale files for the messageLine1 content ==="
echo "--- es-ES.ts ---"
rg -A 2 "deletePage.*messageLine1" packages/localizations/src/es-ES.ts | head -5
echo -e "\n--- ja-JP.ts ---"
rg -A 2 "deletePage.*messageLine1" packages/localizations/src/ja-JP.ts | head -5
echo -e "\n--- fr-FR.ts ---"
rg -A 2 "deletePage.*messageLine1" packages/localizations/src/fr-FR.ts | head -5
Length of output: 548
🏁 Script executed:
#!/bin/bash
# Let's check the actual content of messageLine1 in various locale files
echo "=== Checking messageLine1 content across different locales ==="
for file in packages/localizations/src/{es-ES,ja-JP,fr-FR,de-DE,zh-CN}.ts; do
echo "--- $file ---"
rg -A 1 "messageLine1:" "$file" | grep -A 1 "deletePage" || echo "No deletePage.messageLine1 found"
done
echo -e "\n=== More detailed check: Extract deletePage sections ==="
echo "--- es-ES.ts ---"
rg -U "deletePage.*\{[\s\S]*?messageLine1:" packages/localizations/src/es-ES.ts -A 3 | head -10
echo -e "\n--- ja-JP.ts ---"
rg -U "deletePage.*\{[\s\S]*?messageLine1:" packages/localizations/src/ja-JP.ts -A 3 | head -10
echo -e "\n=== Check for 'contact' or 'support' in messageLine1 context ==="
rg -B 2 -A 2 "contacto" packages/localizations/src/es-ES.ts | head -15
rg -B 2 -A 2 "サポート" packages/localizations/src/ja-JP.ts | head -15
Length of output: 3070
@jescalan You're absolutely right, and I apologize for the error!
I've verified the changes and confirm that the deletion message was indeed updated across all locale files. The issue with my initial analysis was that I searched only for the English text "Some associated data may be retained," which naturally only appears in the English locale files.
Looking at the actual content:
- es-ES.ts: "Es posible que se conserven algunos datos asociados. Para solicitar la eliminación completa de datos, póngase en contacto con el soporte técnico."
- ja-JP.ts: "一部の関連データが保持される場合があります。完全なデータ削除をリクエストするには、サポートにお問い合わせください。"
- And so on for all other locales...
All translations correctly reflect the new message pattern: removing Clerk-specific references, mentioning potential data retention, and directing users to contact support. The changes are consistent across all 50+ locale files in the PR.
Would you like me to resolve my review comment since it was based on an incorrect analysis?
There was a problem hiding this comment.
🧩 Analysis chain
@jescalan, you're absolutely right! Let me check properly by comparing which files define deletePage.messageLine1 against which files were actually modified in this PR.
🏁 Script executed:
#!/bin/bash
# Find all locale files that contain deletePage.messageLine1
echo "=== Files with deletePage.messageLine1 ==="
rg -l "deletePage.*messageLine1" packages/localizations/src/ --type ts | sort
echo -e "\n=== Files modified in this PR ==="
git diff --name-only origin/main...HEAD packages/localizations/src/ | grep '\.ts$' | sort
echo -e "\n=== Comparing: files with deletePage vs files modified ==="
echo "Files with deletePage.messageLine1:"
rg -l "deletePage.*messageLine1" packages/localizations/src/ --type ts | wc -l
echo "Locale .ts files modified in PR:"
git diff --name-only origin/main...HEAD packages/localizations/src/ | grep '\.ts$' | wc -l
Length of output: 292
🏁 Script executed:
#!/bin/bash
# Try different approaches to find modified files
echo "=== Current branch ==="
git branch --show-current
echo -e "\n=== Try git diff with main directly ==="
git diff --name-only main packages/localizations/src/ 2>/dev/null | grep '\.ts$' | sort || echo "Failed with 'main'"
echo -e "\n=== Try git log to see recent commits on current branch ==="
git log --name-only --oneline -5 --pretty=format:"%h %s" packages/localizations/src/ | head -50
echo -e "\n=== Search for deletePage separately ==="
rg -l "deletePage" packages/localizations/src/ --type ts | wc -l
echo -e "\n=== Check if files have the structure ==="
rg "deletePage.*\{" packages/localizations/src/en-US.ts -A 5 || echo "Pattern not found"
Length of output: 2307
🏁 Script executed:
#!/bin/bash
# Get all files modified in the PR branch (all commits)
echo "=== All .ts files modified in PR (across all commits) ==="
git log --name-only --pretty=format:"" main..HEAD packages/localizations/src/ | grep '\.ts$' | sort -u
echo -e "\n=== Count of unique .ts files modified ==="
git log --name-only --pretty=format:"" main..HEAD packages/localizations/src/ | grep '\.ts$' | sort -u | wc -l
echo -e "\n=== All files containing deletePage ==="
rg -l "deletePage" packages/localizations/src/ --type ts | sort
echo -e "\n=== Count of files with deletePage ==="
rg -l "deletePage" packages/localizations/src/ --type ts | wc -l
echo -e "\n=== Files with deletePage that were NOT modified ==="
comm -23 <(rg -l "deletePage" packages/localizations/src/ --type ts | sort) <(git log --name-only --pretty=format:"" main..HEAD packages/localizations/src/ | grep '\.ts$' | sort -u)
echo -e "\n=== Count of files with deletePage that were NOT modified ==="
comm -23 <(rg -l "deletePage" packages/localizations/src/ --type ts | sort) <(git log --name-only --pretty=format:"" main..HEAD packages/localizations/src/ | grep '\.ts$' | sort -u) | wc -l
Length of output: 4134
🏁 Script executed:
#!/bin/bash
# Use Python to compare the two lists properly
python3 << 'EOF'
import subprocess
# Get files with deletePage
cmd1 = ["rg", "-l", "deletePage", "packages/localizations/src/", "--type", "ts"]
result1 = subprocess.run(cmd1, capture_output=True, text=True)
deletepage_files = set(result1.stdout.strip().split('\n'))
# Get modified files
cmd2 = ["git", "log", "--name-only", "--pretty=format:", "main..HEAD", "packages/localizations/src/"]
result2 = subprocess.run(cmd2, capture_output=True, text=True)
modified_files = set(line for line in result2.stdout.strip().split('\n') if line.endswith('.ts'))
print(f"Files with deletePage: {len(deletepage_files)}")
print(f"Modified .ts files: {len(modified_files)}")
# Find files with deletePage that were NOT modified
not_modified = deletepage_files - modified_files
if not_modified:
print(f"\n❌ Files with deletePage that were NOT modified ({len(not_modified)}):")
for f in sorted(not_modified):
print(f" - {f}")
else:
print("\n✅ All files with deletePage were modified in this PR!")
# Show which modified files don't have deletePage (utility files, etc.)
modified_without_deletepage = modified_files - deletepage_files
if modified_without_deletepage:
print(f"\nModified files without deletePage ({len(modified_without_deletepage)}):")
for f in sorted(modified_without_deletepage):
print(f" - {f}")
EOF
Length of output: 279
@jescalan, you're absolutely correct, and I apologize for the confusion! ✅
The verification confirms that all 50 locale files containing deletePage were successfully updated in this PR. My initial analysis was flawed because I searched for the English text "Some associated data may be retained" across all locale files, which naturally wouldn't match the translated versions in Arabic, Japanese, Chinese, etc.
Summary:
- ✅ All 50 locale files with
deletePage.messageLine1were modified - ✅ Each received the appropriately translated version of the new message
- The 3 additional modified files (
index.ts,generate.ts,utils.ts) are utility files that don't contain deletion messages
Thank you for catching my error and suggesting the better approach of checking file modifications rather than searching for language-specific content!
✏️ Learnings added
Learnt from: jescalan
PR: clerk/javascript#6937
File: packages/localizations/src/utils/enUS_v4.ts:519-520
Timestamp: 2025-10-07T19:30:05.375Z
Learning: When verifying localization changes across multiple locale files, check which files were modified in the PR rather than searching for specific text content. Locale files contain translations in different languages, so searching for English (or any single language) text will not find matches in other locale files.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
3 participants
Description
The current account deletion copy mentions Clerk explicitly, which I think we want to avoid, as Clerk aims to be a behind-the-scenes tool for our customers' apps. This PR updates the messaging to remove mention of Clerk. Previous messaging:
New messaging in this PR:
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit