-
Notifications
You must be signed in to change notification settings - Fork 401
fix(clerk-js): Collapse sections after uploading/removing avatars #7044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(clerk-js): Collapse sections after uploading/removing avatars #7044
Conversation
🦋 Changeset detectedLatest commit: 5d826fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughBoth OrganizationProfile and UserProfile ProfileForm components now invoke an optional onSuccess callback after successful avatar upload or removal; a new changeset file for a patch release was added. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant PF as ProfileForm
participant S as Storage/API
participant C as CardState
U->>PF: initiate avatar upload/remove
PF->>S: setLogo(file|null)
alt success
S-->>PF: success
PF->>C: card.setIdle()
note right of PF #DFF2E1: new step
PF-->>U: onSuccess?()
else error
S-->>PF: error
PF-->>U: handleError
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.changeset/three-zebras-boil.md (1)
5-5: Use hyphen for compound modifier: "auto-collapse".The static analysis tool flagged a grammar issue. When "auto" and "collapse" modify the noun phrase "the profile section," they should be hyphenated as a compound adjective.
Apply this diff:
-Improve avatar upload and removal UX to auto collapse the profile section upon successful save. +Improve avatar upload and removal UX to auto-collapse the profile section upon successful save.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.changeset/three-zebras-boil.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Automated releases must use Changesets.
Files:
.changeset/three-zebras-boil.md
🪛 LanguageTool
.changeset/three-zebras-boil.md
[grammar] ~5-~5: Use a hyphen to join words.
Context: ...ove avatar upload and removal UX to auto collapse the profile section upon succes...
(QB_NEW_EN_HYPHEN)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: semgrep-cloud-platform/scan
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
Description
Improves UX of uploading an avatar within the profile components, by auto collapsing the ProfileSection upon successful upload/removal. Avoids the user needing to click
Cancelto close the section.BEFORE
Screen.Recording.2025-10-21.at.4.02.05.PM.mov
AFTER
Screen.Recording.2025-10-21.at.4.01.08.PM.mov
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit