Skip to content

Conversation

@alexcarpenter
Copy link
Member

Description

Smooth out the height change when enabling

Screen.Recording.2025-11-19.at.3.03.42.PM.mov

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel
Copy link

vercel bot commented Nov 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clerk-js-sandbox Ready Ready Preview Comment Nov 19, 2025 10:16pm

@changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2025

⚠️ No Changeset found

Latest commit: 90fe453

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 19, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch alexcarpenter/animate-height-switch

Comment @coderabbitai help to get the list of available commands and usage tips.

onChange={() => setAllowPersonalAccount(prev => !prev)}
/>
</Flex>
{hasPersonalAccountsEnabled && (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to rollback the isEnabled here

@LauraBeatris LauraBeatris merged commit 0893768 into laura/enable-orgs Nov 19, 2025
5 of 6 checks passed
@LauraBeatris LauraBeatris deleted the alexcarpenter/animate-height-switch branch November 19, 2025 22:15
LauraBeatris added a commit that referenced this pull request Nov 19, 2025
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>
LauraBeatris added a commit that referenced this pull request Nov 20, 2025
Co-authored-by: Laura Beatris <48022589+LauraBeatris@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants