Skip to content

feat(ui): Switch to ESM only builds #7264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2025
Merged

feat(ui): Switch to ESM only builds #7264

merged 1 commit into from
Nov 21, 2025

Conversation

@nikosdouvlis
Copy link
Member

@nikosdouvlis nikosdouvlis commented Nov 20, 2025

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 54fbc48

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clerk-js-sandbox Ready Ready Preview Comment Nov 20, 2025 5:42pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 20, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch nikos/make-ui-esm-only

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 20, 2025 •
edited
Loading

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7264

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7264

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7264

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7264

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7264

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7264

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@7264

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7264

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7264

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7264

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7264

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7264

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7264

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7264

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7264

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7264

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7264

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7264

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7264

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@7264

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7264

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7264

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7264

commit: 54fbc48

panteliselef
panteliselef reviewed Nov 20, 2025
View reviewed changes
packages/ui/rspack.config.js
Comment on lines +2 to 12
import rspack from '@rspack/core';
import packageJSON from './package.json' with { type: 'json' };
import path from 'path';
import { fileURLToPath } from 'url';
import { merge } from 'webpack-merge';
import ReactRefreshPlugin from '@rspack/plugin-react-refresh';
import { svgLoader, typescriptLoaderProd, typescriptLoaderDev } from '../../scripts/rspack-common.js';

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);

Copy link
Member

@panteliselef panteliselef Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikosdouvlis do we still need this file ?

Copy link
Member Author

@nikosdouvlis nikosdouvlis Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tagging @dstaley to answer both questions at the same time :)
rspack.config.mjs should be rspack.config.js - I think I managed to stage only some of the changes and the delta here is weird. Pushing a fix in a bit

dstaley
dstaley reviewed Nov 20, 2025
View reviewed changes
packages/ui/package.json
"clean": "rimraf ./dist",
"dev": "rspack serve --config rspack.config.js",
"dev:origin": "rspack serve --config rspack.config.js --env devOrigin=http://localhost:${PORT:-4001}",
"dev": "rspack serve --config rspack.config.mjs",
Copy link
Member

@dstaley dstaley Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"type": "module" will treat all files in the current directory as ESM by default, so shouldn't this be rspack.config.js? I don't think we need the .mjs extension.

@nikosdouvlis nikosdouvlis force-pushed the nikos/make-ui-esm-only branch from d1aa413 to 54fbc48 Compare November 20, 2025 17:40
@nikosdouvlis nikosdouvlis merged commit a888d47 into vincent-and-the-doctor Nov 21, 2025
32 of 46 checks passed
@nikosdouvlis nikosdouvlis deleted the nikos/make-ui-esm-only branch November 21, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dstaley dstaley dstaley left review comments

@panteliselef panteliselef panteliselef left review comments

Assignees

No one assigned

Labels

themes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nikosdouvlis @dstaley @panteliselef @clerk-cookie