Skip to content

Conversation

@octoper
Copy link
Member

@octoper octoper commented Nov 20, 2025

Description

Updates the keyless e2e test to user the correct dashboard redirect url for assertions

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Tests
    • Updated keyless quickstart sign-up test to expect a redirect to the "prepare-account" path while retaining the check for the encoded app-claim token.
    • Confirmed no exported or public interfaces were added, removed, or modified.
  • Chores
    • Added a small changeset file for release bookkeeping.

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2025

🦋 Changeset detected

Latest commit: 6958003

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@octoper octoper self-assigned this Nov 20, 2025
@vercel
Copy link

vercel bot commented Nov 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clerk-js-sandbox Ready Ready Preview Comment Nov 20, 2025 0:42am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 20, 2025

Walkthrough

Updated a sign-up redirect check in integration/tests/next-quickstart-keyless.test.ts to use startsWith(${dashboardUrl}prepare-account) instead of workspace-selection while keeping the includes(encodeURIComponent('apps/claim?token=')) check. Added a new changelog file .changeset/rare-birds-turn.md containing two YAML document separators.

Changes

Cohort / File(s) Change Summary
Sign-up flow test redirect update
integration/tests/next-quickstart-keyless.test.ts
Replaced workspace-selection prefix check with prepare-account in the sign-up force-redirect URL condition; preserved the includes(encodeURIComponent('apps/claim?token=')) check. No other logic changes.
Changeset added
.changeset/rare-birds-turn.md
Added new changeset file containing two YAML document separators (---) with a blank line between them.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Very small, localized string change in a test and a simple new file; review mainly for correctness of the test expectation and the changeset contents.

Poem

🐰 I hopped through code at break of dawn,
A tiny path of routes redrawn.
From workspace lanes to prepare-account,
A gentle nudge — a cheerful bounce.
New changelog leaf where small notes fawn.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the signUpForceRedirectUrl check from workspace-selection to prepare-account in the keyless e2e test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch vaggelis/update-keyless-tests-redirect-url

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 56b7861 and 6958003.

📒 Files selected for processing (1)
  • .changeset/rare-birds-turn.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • .changeset/rare-birds-turn.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (33)
  • GitHub Check: Integration Tests (nextjs, chrome, 16)
  • GitHub Check: Integration Tests (billing, chrome, RQ)
  • GitHub Check: Integration Tests (quickstart, chrome, 15)
  • GitHub Check: Integration Tests (quickstart, chrome, 16)
  • GitHub Check: Integration Tests (custom, chrome)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 15, RQ)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 14)
  • GitHub Check: Integration Tests (elements, chrome)
  • GitHub Check: Integration Tests (expo-web, chrome)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (sessions:staging, chrome)
  • GitHub Check: Integration Tests (handshake, chrome)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (handshake:staging, chrome)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Publish with pkg-pr-new
  • GitHub Check: Unit Tests (22, shared, clerk-js, RQ)
  • GitHub Check: Static analysis
  • GitHub Check: Unit Tests (22, **)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
integration/tests/next-quickstart-keyless.test.ts (1)

93-93: Remove debug console.log statement.

The console.log appears to be a debugging artifact that should be removed before merging to keep test output clean and focused.

Apply this diff to remove the debug statement:

-      console.log('signUpForceRedirectUrlCheck', signUpForceRedirectUrlCheck);
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3438d17 and d02e1d6.

📒 Files selected for processing (1)
  • integration/tests/next-quickstart-keyless.test.ts (1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
integration/tests/next-quickstart-keyless.test.ts (1)
packages/clerk-js/src/utils/redirectUrls.ts (1)
  • signUpForceRedirectUrl (64-106)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (32)
  • GitHub Check: Integration Tests (quickstart, chrome, 15)
  • GitHub Check: Integration Tests (quickstart, chrome, 16)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (nextjs, chrome, 15, RQ)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 16)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (billing, chrome, RQ)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (nextjs, chrome, 14)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (expo-web, chrome)
  • GitHub Check: Integration Tests (custom, chrome)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (handshake:staging, chrome)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Integration Tests (sessions:staging, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: Integration Tests (elements, chrome)
  • GitHub Check: Integration Tests (handshake, chrome)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Publish with pkg-pr-new
  • GitHub Check: Unit Tests (22, shared, clerk-js, RQ)
  • GitHub Check: Static analysis
  • GitHub Check: Unit Tests (22, **)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
integration/tests/next-quickstart-keyless.test.ts (1)

89-92: LGTM! Redirect path updated correctly.

The change from workspace-selection to prepare-account aligns the test with the current dashboard behavior. The logic correctly verifies that the redirect URL points to the prepare-account flow while preserving the token parameter check.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 20, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7266

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7266

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7266

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7266

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7266

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7266

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@7266

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@7266

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7266

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7266

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7266

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7266

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7266

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7266

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@7266

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7266

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@7266

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7266

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7266

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7266

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@7266

@clerk/types

npm i https://pkg.pr.new/@clerk/types@7266

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7266

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7266

commit: 6958003

@octoper octoper enabled auto-merge (squash) November 20, 2025 12:41
@octoper octoper merged commit 5068f1c into main Nov 20, 2025
45 checks passed
@octoper octoper deleted the vaggelis/update-keyless-tests-redirect-url branch November 20, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants