Skip to content

Conversation

@jacekradko
Copy link
Member

@jacekradko jacekradko commented Nov 21, 2025

Description

Removing the custom variant for testing out BroadcastChannel functionality. This functionality is now part of the core browser build

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Chores
    • Removed the BroadcastChannel build variant and related development infrastructure (build configs, dev script, and build-time flag).
    • Stopped watching the channel bundle in bundle size checks.
    • Removed the build flag from test configuration.
    • Added an empty changeset placeholder file.

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2025

🦋 Changeset detected

Latest commit: ec96517

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clerk-js-sandbox Ready Ready Preview Comment Nov 25, 2025 2:57am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 21, 2025

Walkthrough

Removes the clerkChannelBrowser build variant and its BroadcastChannel preset: deletes the preset export, build-time flag, dev script, bundlewatch entry, and associated rspack/vitest/type declarations across several config and source files.

Changes

Cohort / File(s) Change Summary
Integration & Presets
integration/presets/envs.ts
Removed withBroadcastChannel local declaration and its export from the envs list.
Rspack build config
packages/clerk-js/rspack.config.js
Removed clerkChannelBrowser variant, its mapping in variantToSourceFile, its DefinePlugin flag, and all dev/prod config entries and merges related to this variant.
Package scripts
packages/clerk-js/package.json
Removed the dev:channel npm script.
Bundle monitoring
packages/clerk-js/bundlewatch.config.json
Removed the entry for ./dist/clerk.channel.browser.js.
Type & test defs
packages/clerk-js/src/global.d.ts, packages/clerk-js/vitest.config.mts
Deleted the declare const __BUILD_VARIANT_CHANNEL__: boolean; and removed __BUILD_VARIANT_CHANNEL__ from Vitest define config.
Meta / changeset
.changeset/nice-planes-glow.md
Added new changeset file (placeholder content).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Mostly consistent removals across configs and declarations.
  • Pay attention to:
    • Any remaining references to clerkChannelBrowser or __BUILD_VARIANT_CHANNEL__ in the repo (search).
    • Build/test pipelines or CI configs that may still expect the removed script or artifact.
    • Bundlewatch thresholds if other entries rely on the removed file.

Poem

🐰 I nudged a variant out to roam,
I folded flags and sent scripts home.
A tiny hop, a cleaner view —
The build-light bounces, fresh and new. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: removing the BroadcastChannel build variant from clerk-js, which is confirmed across all file modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/remove-channel-variant

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 5ee3680 and ec96517.

📒 Files selected for processing (1)
  • .changeset/nice-planes-glow.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • .changeset/nice-planes-glow.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (34)
  • GitHub Check: Integration Tests (quickstart, chrome, 16)
  • GitHub Check: Integration Tests (machine, chrome, RQ)
  • GitHub Check: Integration Tests (nextjs, chrome, 15)
  • GitHub Check: Integration Tests (nextjs, chrome, 16)
  • GitHub Check: Integration Tests (nextjs, chrome, 15, RQ)
  • GitHub Check: Integration Tests (machine, chrome)
  • GitHub Check: Integration Tests (quickstart, chrome, 15)
  • GitHub Check: Integration Tests (nextjs, chrome, 14)
  • GitHub Check: Integration Tests (expo-web, chrome)
  • GitHub Check: Integration Tests (billing, chrome)
  • GitHub Check: Integration Tests (billing, chrome, RQ)
  • GitHub Check: Integration Tests (react-router, chrome)
  • GitHub Check: Integration Tests (nuxt, chrome)
  • GitHub Check: Integration Tests (astro, chrome)
  • GitHub Check: Integration Tests (tanstack-react-start, chrome)
  • GitHub Check: Integration Tests (localhost, chrome)
  • GitHub Check: Integration Tests (vue, chrome)
  • GitHub Check: Integration Tests (sessions:staging, chrome)
  • GitHub Check: Integration Tests (custom, chrome)
  • GitHub Check: Integration Tests (handshake, chrome)
  • GitHub Check: Integration Tests (handshake:staging, chrome)
  • GitHub Check: Integration Tests (ap-flows, chrome)
  • GitHub Check: Integration Tests (sessions, chrome)
  • GitHub Check: Integration Tests (generic, chrome)
  • GitHub Check: Integration Tests (elements, chrome)
  • GitHub Check: Integration Tests (express, chrome)
  • GitHub Check: Publish with pkg-pr-new
  • GitHub Check: Unit Tests (22, **)
  • GitHub Check: Static analysis
  • GitHub Check: Unit Tests (22, shared, clerk-js, RQ)
  • GitHub Check: Formatting | Dedupe | Changeset
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 21, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7288

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7288

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7288

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7288

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7288

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7288

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@7288

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@7288

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7288

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7288

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7288

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7288

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7288

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7288

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@7288

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7288

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@7288

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7288

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7288

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7288

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@7288

@clerk/types

npm i https://pkg.pr.new/@clerk/types@7288

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7288

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7288

commit: ec96517

@jacekradko jacekradko merged commit b248601 into main Nov 25, 2025
45 of 46 checks passed
@jacekradko jacekradko deleted the feat/remove-channel-variant branch November 25, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants