Skip to content

Conversation

@kduprey
Copy link
Contributor

@kduprey kduprey commented Dec 9, 2025

Description

Adds unique element descriptors for Web3 Wallet buttons to allow for customisation via the appearance prop.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

…ent descriptors for Web3 wallet buttons

Signed-off-by: Kenton Duprey <kenton@clerk.dev>
@kduprey kduprey requested a review from alexcarpenter December 9, 2025 21:16
@kduprey kduprey self-assigned this Dec 9, 2025
@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2025

⚠️ No Changeset found

Latest commit: c6daf4f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clerk-js-sandbox Ready Ready Preview Comment Dec 9, 2025 9:17pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 9, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch kenton/add-element-descriptors-to-web3-wallet-buttons

Comment @coderabbitai help to get the list of available commands and usage tips.

@kduprey kduprey changed the title feat(clerk-js,types): Add WalletInitialIcon component and update element descriptors for Web3 wallet buttons feat(clerk-js,types): Add WalletInitialIcon, update element descriptors for Web3 wallet buttons Dec 9, 2025
Copy link
Member

@alexcarpenter alexcarpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@kduprey kduprey merged commit cf118cc into kenton/user-3770-add-functionality-to-clerk-js-to-be-able-to-detect-all Dec 9, 2025
7 of 8 checks passed
@kduprey kduprey deleted the kenton/add-element-descriptors-to-web3-wallet-buttons branch December 9, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants