Skip to content

chore(types,localizations): New localization keys for max length exceeded validation#1521

Merged
nikospapcom merged 1 commit intomainfrom
nikospap/dsh-301
Jul 26, 2023
Merged

chore(types,localizations): New localization keys for max length exceeded validation#1521
nikospapcom merged 1 commit intomainfrom
nikospap/dsh-301

Conversation

@nikospapcom
Copy link
Copy Markdown
Contributor

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

Description

  • npm test runs as expected.
  • npm run build runs as expected.

New localization keys for max length exceeded validation:

  • Organization name (form_param_max_length_exceeded__name)
  • First name (form_param_max_length_exceeded__first_name)
  • Last name (form_param_max_length_exceeded__last_name)

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jul 25, 2023

🦋 Changeset detected

Latest commit: 361c889

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@clerk/localizations Patch
@clerk/types Patch
@clerk/clerk-js Patch
@clerk/backend Patch
@clerk/clerk-expo Patch
@clerk/fastify Patch
gatsby-plugin-clerk Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
@clerk/chrome-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pwned: 'If you use this password elsewhere, you should change it.',
},
},
form_param_max_length_exceeded__name: 'Name should not exceed 256 characters.',
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double checking - is this the same error FAPI returns?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @nikosdouvlis , it's the same error

Copy link
Copy Markdown

@jit-ci jit-ci Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Great news! Jit hasn't found any security issues in your PR. Good Job! 🏆

@nikospapcom nikospapcom merged commit d433b83 into main Jul 26, 2023
@nikospapcom nikospapcom deleted the nikospap/dsh-301 branch July 26, 2023 06:05
@clerk-cookie clerk-cookie mentioned this pull request Jul 26, 2023
@clerk-cookie
Copy link
Copy Markdown
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants