feat(clerk-js): Reject a membership request as an organization admin#1612
Merged
panteliselef merged 4 commits intomainfrom Aug 21, 2023
Merged
feat(clerk-js): Reject a membership request as an organization admin#1612panteliselef merged 4 commits intomainfrom
panteliselef merged 4 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 65f02c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
chanioxaris
approved these changes
Aug 18, 2023
| sx={avatarSx} | ||
| rounded={rounded} | ||
| /> | ||
| {imageUrl ? ( |
Member
There was a problem hiding this comment.
❓ What is this change about?
Contributor
Author
There was a problem hiding this comment.
This is necessary, because
- We don't want to display the elements if imageUrl does not exist as the html element will reserve space
- We cannot use
showAvatarbecause it will still an element that just reserves height (necessary for switcher)
Added a comment in the code, as to why this is needed
anagstef
approved these changes
Aug 21, 2023
Merged
Collaborator
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.