fix(nextjs): Only ignore paths that have a '.' in the final path segment#1695
Merged
fix(nextjs): Only ignore paths that have a '.' in the final path segment#1695
Conversation
🦋 Changeset detectedLatest commit: 20370a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brkalow
requested review from
SokratisVidros and
nikosdouvlis
as code owners
dimkl
reviewed
Sep 8, 2023
dimkl
reviewed
Sep 8, 2023
SokratisVidros
approved these changes
Sep 11, 2023
dimkl
approved these changes
Sep 12, 2023
anagstef
approved these changes
Sep 12, 2023
brkalow
force-pushed
the
brk.fix/next-match-static-assets
branch
from
4dfccd5 to
da06d41
Compare
Merged
Collaborator
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.Updates our middleware default matcher and
IGNORED_ROUTESpattern to allow matching of paths that contain a.that is not in the last path segment, but does not match paths that contain a.in the last segment (presumably this would be a static asset).Fixes JS-694